Skip to content

fix(deps): resolve 5 open Dependabot alerts across nested sharp/hono/fast-uri pins#8096

Merged
JSONbored merged 1 commit into
mainfrom
claude/loopover-security-vulnerabilities-4f3f29
Jul 22, 2026
Merged

fix(deps): resolve 5 open Dependabot alerts across nested sharp/hono/fast-uri pins#8096
JSONbored merged 1 commit into
mainfrom
claude/loopover-security-vulnerabilities-4f3f29

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves — N/A, owner PR fixing 5 currently-open repo-native Dependabot security alerts directly (not a contributor-issue-driven change).

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally (no src/** lines changed — dependency-only PR, nothing to cover)
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate (root and control-plane, both report 0 vulnerabilities)
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries — N/A, no src/** behavior changed, dependency-lockfile-only PR

Ran the full local gate via npm run test:ci, green end to end.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests. — N/A, no such changes.
  • API/OpenAPI/MCP behavior is updated and tested where needed. — N/A, no API/OpenAPI/MCP behavior changed.
  • UI changes use live API data or real empty/error/loading states. — N/A, no UI changes.
  • Visible UI changes include a UI Evidence section. — N/A, no visible UI changes (verified ui:build still succeeds).
  • Public docs/changelogs are updated where needed. — N/A, no docs/changelog changes.

Notes

  • One implementation snag worth recording: an initial, broader lockfile edit (stripping the whole nested packages/discovery-index/node_modules/* subtree for wrangler/miniflare) fixed the vulnerabilities but had a collateral side effect — npm re-hoisted @lovable.dev/vite-tanstack-config to the workspace root, which broke its nitro peer resolution and silently failed ui:build. Caught only because the full test:ci gate was actually run to completion rather than trusted from a truncated/piped log. The final diff uses a much narrower two-entry lockfile fix (sharp + @hono/node-server only) that resolves cleanly without that side effect.

…fast-uri pins

fast-uri (ajv transitive) was pinned below the host-confusion patches
(GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6). sharp and @hono/node-server
were already patched at the root, but miniflare/wrangler/@modelcontextprotocol-sdk
transitively pinned older, vulnerable copies nested under
packages/discovery-index and control-plane (GHSA-f88m-g3jw-g9cj,
GHSA-frvp-7c67-39w9). Added npm overrides to force the patched versions
everywhere, and aligned discovery-index's wrangler floor with root's so
the two dedupe into a single install instead of a private nested copy.

npm audit and Dependabot both report 0 open advisories on both lockfiles
after this change.
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
loopover-ui b43e6ef Commit Preview URL

Branch Preview URL
Jul 22 2026, 10:11 PM

@JSONbored JSONbored self-assigned this Jul 22, 2026
@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (ed9e296) to head (b43e6ef).
⚠️ Report is 3 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8096   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files         752      752           
  Lines       76979    76979           
  Branches    23315    23316    +1     
=======================================
  Hits        70820    70820           
  Misses       5053     5053           
  Partials     1106     1106           
Flag Coverage Δ
control-plane 99.82% <ø> (ø)
shard-1 54.92% <ø> (-0.01%) ⬇️
shard-2 54.13% <ø> (ø)
shard-3 54.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 22, 2026
@loopover-orb

loopover-orb Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Warning

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-22 22:23:39 UTC

5 files · 1 AI reviewer · 2 blockers · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a straightforward dependency-security PR: it adds npm `overrides` for `sharp`, `fast-uri`, and `@​hono/node-server` to force nested/transitive installs onto patched versions, and aligns `packages/discovery-index`'s `wrangler` floor with root to dedupe the install. The lockfiles confirm the overrides actually took effect — old `sharp@​0.34.5`/`@​img/sharp-libvips-*@​1.2.4` entries and the duplicate nested `@​hono/node-server@​1.19.14` under `@​modelcontextprotocol/sdk` and `discovery-index` are gone, replaced by the single deduped `sharp@​0.35.3`/`libvips@​1.3.2` and root `@​hono/node-server@​2.0.8`. The `control-plane/package.json` override for `sharp` alone (no `fast-uri`/`@​hono/node-server`) is consistent with control-plane's dependency tree (it doesn't depend on hono/ajv chains that would pull those in), so the scoping looks correct rather than incomplete.

Nits — 3 non-blocking
  • The PR checklist marks the 'linked open issue' box unchecked with a maintainer-authorized rationale ('owner PR fixing repo-native Dependabot alerts') — confirm this exemption is accepted for security-alert-driven PRs generally, since the stated review policy otherwise requires an issue link.
  • The external brief flags `@​hono/node-server@​2.0.8` against an 'unknown'-severity GHSA-9mqv-5hh9-4cgg entry with no detail — worth a quick check that `2.0.8` is actually patched for that specific advisory before treating this override as fully resolving Dependabot alert scope.
  • Nothing else needed here beyond what's already in the PR — lockfiles show the overrides resolved as intended and the wrangler floor change achieves the stated dedupe goal.

Concerns raised — review before merging

  • No linked issue detected: No closing reference or linked issue number was found in the PR metadata/body. — If this PR is intended to solve an issue, link it explicitly in the PR body.
  • Maintainer requires a linked issue: This repo's maintainer focus manifest requires every PR to reference a tracked issue. — Link the relevant issue (for example Closes #123) before opening the PR.
📋 Copy for AI agents — paste into your coding agent
Fix the following blocker(s) from this PR review:

1. No linked issue detected: No closing reference or linked issue number was found in the PR metadata/body. — If this PR is intended to solve an issue, link it explicitly in the PR body.

2. Maintainer requires a linked issue: This repo's maintainer focus manifest requires every PR to reference a tracked issue. — Link the relevant issue (for example `Closes #123`) before opening the PR.

Decision drivers

  • ❌ Code review — 2 blockers (1 reviewer)
  • ❌ Gate result — Blocking (Repo-configured hard blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 14 registered-repo PR(s), 14 merged, 242 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 14 PR(s), 242 issue(s).
Improvement ℹ️ Insufficient signal risk: clean · value: insufficient-signal · LLM: moderate
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 14 PR(s), 242 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Then work through the remaining 2 steps in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 22, 2026
@JSONbored
JSONbored merged commit 653a391 into main Jul 22, 2026
16 checks passed
@JSONbored
JSONbored deleted the claude/loopover-security-vulnerabilities-4f3f29 branch July 22, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant