fix(deps): resolve 5 open Dependabot alerts across nested sharp/hono/fast-uri pins#8096
Conversation
…fast-uri pins fast-uri (ajv transitive) was pinned below the host-confusion patches (GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6). sharp and @hono/node-server were already patched at the root, but miniflare/wrangler/@modelcontextprotocol-sdk transitively pinned older, vulnerable copies nested under packages/discovery-index and control-plane (GHSA-f88m-g3jw-g9cj, GHSA-frvp-7c67-39w9). Added npm overrides to force the patched versions everywhere, and aligned discovery-index's wrangler floor with root's so the two dedupe into a single install instead of a private nested copy. npm audit and Dependabot both report 0 open advisories on both lockfiles after this change.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | b43e6ef | Commit Preview URL Branch Preview URL |
Jul 22 2026, 10:11 PM |
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8096 +/- ##
=======================================
Coverage 91.99% 91.99%
=======================================
Files 752 752
Lines 76979 76979
Branches 23315 23316 +1
=======================================
Hits 70820 70820
Misses 5053 5053
Partials 1106 1106
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-22 22:23:39 UTC
Review summary Nits — 3 non-blocking
Concerns raised — review before merging
📋 Copy for AI agents — paste into your coding agentDecision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
overrides— these were transitive/nested pins, not direct dependencies, so bumping the top-level manifest alone didn't reach them.fast-uri(pulled in byajv) was below the host-confusion patches: GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6. Overridden to^3.1.4.sharpand@hono/node-serverwere already patched at the root, butminiflare(viawrangler) and@modelcontextprotocol/sdktransitively pinned older, vulnerable copies nested underpackages/discovery-indexand the separatecontrol-planeproject — GHSA-f88m-g3jw-g9cj (sharp/libvips), GHSA-frvp-7c67-39w9 (hono path traversal). Overridden to^0.35.0/^2.0.8respectively in bothpackage.jsonandcontrol-plane/package.json.packages/discovery-index'swranglerfloor from^4.112.0to^4.107.0(matching root) so the two workspaces dedupe into a singlewrangler/miniflareinstall instead of each holding a private nested copy that could silently drift from the override again.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally (nosrc/**lines changed — dependency-only PR, nothing to cover)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderate(root andcontrol-plane, both report 0 vulnerabilities)src/**behavior changed, dependency-lockfile-only PRRan the full local gate via
npm run test:ci, green end to end.Safety
UI Evidencesection. — N/A, no visible UI changes (verifiedui:buildstill succeeds).Notes
packages/discovery-index/node_modules/*subtree forwrangler/miniflare) fixed the vulnerabilities but had a collateral side effect — npm re-hoisted@lovable.dev/vite-tanstack-configto the workspace root, which broke itsnitropeer resolution and silently failedui:build. Caught only because the fulltest:cigate was actually run to completion rather than trusted from a truncated/piped log. The final diff uses a much narrower two-entry lockfile fix (sharp+@hono/node-serveronly) that resolves cleanly without that side effect.