fix(docs): repair #8182 fallout — audit manifest, mangled runner YAML snippet, kill-switch route assertion#8192
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | bae6731 | Commit Preview URL Branch Preview URL |
Jul 23 2026, 10:19 AM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Bundle ReportChanges will increase total bundle size by 18 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: loopover-uiAssets Changed:
|
loopover-orb
Bot
added
the
gittensor:bug
Contributor
|
Caution 🛑 LoopOver review result - fixes requiredReview updated: 2026-07-23 10:24:56 UTC
Review summary Nits — 4 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentCI checks failing
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
… runner YAML snippet, kill-switch route assertion Three drift tests went red on main when #8182 replaced the per-page docs routes with the dynamic docs.$slug.tsx route: - selfhost-docs-audit's manifest pointed at the deleted docs.*.tsx files; its entries now name the pages' real sources (content/docs/<slug>.mdx). - The whole-tree format pass in that PR stripped the indentation out of self-hosting-operations.mdx's multi-runner docker-compose example, leaving invalid YAML operators would copy-paste; the snippet is restored verbatim (mdx code blocks are not formatter-enforced in CI — eslint-only). - kill-switch-incident-runbook's route assertion now checks the dynamic route that actually serves the page.
JSONbored
force-pushed
the
fix/selfhost-docs-audit-manifest
branch
from
July 23, 2026 10:17
e323203 to
bae6731
Compare
JSONbored
added a commit
that referenced
this pull request
Jul 23, 2026
…, not a missing report (#8195) The third scoped-selection edge case in a week (PR #8192's shards): the selection matched real tests that PASSED but exercised nothing under coverage.include (src/**) — a test-only/docs-drift diff — so --coverage.all=false wrote an empty lcov and 'Verify coverage report exists' failed a green run. no_tests_matched cannot see this case because tests DID match. The scoped branch now derives a second output (no_src_coverage) from the run itself: reachable only on vitest exit 0, detected by the absent/empty lcov, proven by the junit report the same command wrote. Every verify/upload guard carries both escapes, and the codecov-policy drift test pins the full condition strings plus both detector lines so neither can silently vanish. Scoped selection itself stays DISABLED via SCOPED_TEST_SELECTION_ENABLED=false until the re-enable decision documented on the issue. Advances #8194
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8192 +/- ##
===========================================
+ Coverage 61.30% 91.54% +30.23%
===========================================
Files 771 771
Lines 77941 77942 +1
Branches 23544 23546 +2
===========================================
+ Hits 47784 71352 +23568
+ Misses 26508 5524 -20984
+ Partials 3649 1066 -2583
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Main has been red since #8182 (the dynamic docs.$slug.tsx migration). Three drift tests caught real fallout:
docs.*.tsxroute files. Entries now name the pages' real sources since the migration:content/docs/<slug>.mdx(the field is renamedrouteFile→contentFile; it had no other consumer).self-hosting-operations.mdx's multi-runner docker-compose example — invalid YAML an operator would copy-paste. Restored verbatim; thedocs-selfhost-operations-runner-tmpdirdrift test did exactly its job. (Scanned every other mdx that PR touched for the same class of damage — this was the only structured code block affected.)createFileRoutein the deleted per-page route; it now checks the dynamic route that actually serves the page, keeping the nav-entry and content assertions unchanged.Validation
All three suites green locally (
docs-selfhost-audit-checklist,docs-selfhost-operations-runner-tmpdir,kill-switch-incident-runbook); root + UI typecheck green. mdx code blocks are not formatter-enforced in CI (ui:lintis eslint-only), and the restored snippet matches the pre-#8182 content that CI accepted for months.