chore(ui): align prettier across all three UI workspaces and enforce it in the ui:lint chain#8193
Merged
Merged
Conversation
…it in the ui:lint chain Root cause of the #8182 docs mangling: prettier coverage differed between what 'npm run format' would rewrite locally and what CI checked (nothing). Now the three UI workspaces agree everywhere: - .prettierignore in every workspace covers the generated artifacts (openapi.json, routeTree.gen.ts, dist, CHANGELOG.md) and — deliberately — content/docs: prettier's mdx pass reformats the template-literal code inside <CodeBlock code={`...`}> attributes, destroying embedded YAML/compose indentation. Docs mdx stays formatter-free. - One mechanical reformat brings every remaining file to prettier-clean. - Each workspace gains format:check, wired into the root ui:lint chain that CI's validate job and npm run test:ci already run — local format runs and CI now enforce the identical surface, so drift of this class cannot land silently again.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
loopover-ui | d10ae1a | Commit Preview URL Branch Preview URL |
Jul 23 2026, 10:19 AM |
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Bundle ReportBundle size has no change ✅ |
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
JSONbored
added a commit
that referenced
this pull request
Jul 23, 2026
…hree UI workspaces (#8199) The #8193 alignment missed them: a worktree that had run vitest --coverage fails format:check on coverage/lcov-report/** artifacts that are never formatter input. CI checkouts are clean so this only bit local gates -- but local and CI enforcing the identical surface is the point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Permanent fix for the class of damage behind the #8182 docs mangling (repaired in #8192): prettier's coverage differed between what
npm run formatrewrites locally and what CI checks (nothing), so a local format pass could silently rewrite hand-authored or generated content.How
.prettierignorein every UI workspace covering the generated artifacts (public/openapi.json,routeTree.gen.ts,dist, ui-kit'sCHANGELOG.md) and — deliberately —content/docs: prettier's mdx pass reformats the template-literal code inside<CodeBlock code={\…`}>` attributes, destroying embedded YAML indentation (exactly what broke the multi-runner compose example). Docs mdx stays formatter-free; its accuracy is guarded by the drift tests instead.format:checkin each workspace, wired into the rootui:lintchain that CI'svalidatejob andnpm run test:cialready run — local and CI now enforce the identical surface.Validation
ui:lint(with the three new format:checks),ui:typecheck,ui:test, andui:buildall green locally on the reformatted tree. No behavior changes — the non-config diff is purely mechanical formatting.