Skip to content

fix(ui-kit): give PaginationLink aria-disabled a real visual/interaction effect - #8359

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/critical-issue-pagination-aria-disabled-8307
Jul 24, 2026
Merged

fix(ui-kit): give PaginationLink aria-disabled a real visual/interaction effect#8359
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
RealDiligent:fix/critical-issue-pagination-aria-disabled-8307

Conversation

@RealDiligent

Copy link
Copy Markdown
Contributor

Summary

  • PaginationLink renders an <a>, which has no native disabled attribute, and applied no styling keyed off aria-disabled — so the five apps/loopover-miner-ui routes that set aria-disabled on the boundary PaginationPrevious/PaginationNext (run-history.tsx, ledgers.tsx, portfolio.tsx, ranked-candidates.tsx, attempts.tsx) got only a screen-reader signal: the link stayed fully opaque, kept its ghost/outline hover state, and remained pointer-interactive.
  • Adds aria-disabled:pointer-events-none aria-disabled:opacity-50 to PaginationLink's class composition (inherited by PaginationPrevious/PaginationNext, which both delegate to it), matching the exact aria-disabled: styling convention sidebar.tsx (sidebarMenuButtonVariants/SidebarMenuSubButton) and calendar.tsx already use.
  • isActive/aria-current behavior and every consumer's existing aria-disabled={...} usage are untouched — pagination.tsx-only styling fix.
  • Adds pagination.test.tsx (this component's first test): asserts an aria-disabled PaginationLink/PaginationPrevious/PaginationNext carries the disabled-styling classes and that aria-current is unchanged.

Closes #8307

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • This diff touches only packages/loopover-ui-kit/** (one class-composition line + one new test). packages/loopover-ui-kit is not in the root vitest.config.ts coverage.include and is not Codecov-gated (its own vitest.config.ts: the acceptance signal is the suite running and passing, not a percentage), so test:coverage/codecov/patch do not apply; actionlint, test:workers, build:mcp/test:mcp-pack, ui:openapi:check, and npm audit are not exercised by a ui-kit-only class change. Locally verified in the package: npm test (4 files / 22 tests, incl. the 3 new), tsc --noEmit, and prettier --check on the touched files all pass.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

The rendered change is scoped to the aria-disabled="true" state of a pagination control (a boundary PaginationPrevious/PaginationNext), which no ui-kit consumer could exercise before this fix because no aria-disabled: styling existed:

  • Before: a boundary pagination arrow rendered at full opacity, kept its ghost hover highlight, and stayed pointer-interactive — visually identical to an enabled arrow.
  • After: the same aria-disabled arrow renders at opacity-50 with pointer-events-none (hover highlight and clicks suppressed), i.e. the standard dimmed-disabled cue already shown by sidebar.tsx/calendar.tsx's aria-disabled: elements.

The effect is the exact aria-disabled:opacity-50 / aria-disabled:pointer-events-none utility pair those two sibling components already ship, so it inherits their established visual treatment rather than introducing a new one. The machine-checkable evidence is the class-list regression test pagination.test.tsx (part of this PR), which asserts the disabled-styling classes are present on PaginationLink/PaginationPrevious/PaginationNext and that aria-current is unchanged — the same class-list-assertion evidence convention state-views.test.tsx/theme-toggle.test.tsx use for ui-kit variant guarantees.

Notes

@RealDiligent
RealDiligent requested a review from JSONbored as a code owner July 24, 2026 10:47
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

…ction effect

PaginationLink renders an <a>, which has no native disabled attribute, and
applied no styling keyed off aria-disabled — so the five miner-ui routes that
set aria-disabled at page boundaries got only a screen-reader signal, with the
link staying fully opaque, hover-active, and pointer-interactive. Adds
aria-disabled:pointer-events-none aria-disabled:opacity-50 at the PaginationLink
level (inherited by PaginationPrevious/PaginationNext), matching the
aria-disabled: styling convention sidebar.tsx and calendar.tsx already use,
with a class-list regression test.

Closes JSONbored#8307
@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 24, 2026
@loopover-orb

loopover-orb Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-24 10:55:17 UTC

2 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a small, well-targeted fix: PaginationLink renders an `<a>` with no native disabled semantics, so it adds `aria-disabled:pointer-events-none aria-disabled:opacity-50` to the class composition, matching the existing `aria-disabled:` convention used in sidebar.tsx/calendar.tsx. PaginationPrevious/PaginationNext inherit the fix automatically since they delegate to PaginationLink, and the added test file correctly asserts the classes are present and that aria-current/isActive behavior is untouched. The change is minimal, correct, and closes the linked issue #8307 without scope creep.

Nits — 3 non-blocking
  • The third test in pagination.test.tsx (isActive/aria-current case) doesn't actually assert the aria-disabled classes are absent when aria-disabled isn't set — it only checks aria-current, so the 'classes are present regardless' comment is a bit misleading about what's being verified.
  • Consider also asserting `aria-disabled` is NOT applied by default (e.g. a plain PaginationLink without the prop) to guard against the Tailwind arbitrary variant selector ever being satisfied unintentionally.
  • pagination.test.tsx: add a quick negative-case assertion (no aria-disabled attr set → classes still present in className string but el is not effectively disabled/pointer-events default) to fully round out the coverage story implied by the third test's comment.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #8307
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 345 registered-repo PR(s), 134 merged, 39 issue(s).
Contributor context ✅ Confirmed Gittensor contributor RealDiligent; Gittensor profile; 345 PR(s), 39 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: minor
Linked issue satisfaction

Addressed
The diff adds `aria-disabled:pointer-events-none aria-disabled:opacity-50` directly to PaginationLink's class composition, matching the sidebar.tsx/calendar.tsx convention, and adds a test file asserting both PaginationLink and the delegating PaginationPrevious/PaginationNext carry these classes when aria-disabled is set, plus a check that aria-current/isActive behavior is unchanged.

Review context
  • Author: RealDiligent
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, Ruby, JavaScript, Svelte, TypeScript, Cuda, Markdown, MDX
  • Official Gittensor activity: 345 PR(s), 39 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/ desktop before /
before /
after /
after /
/ mobile before / (mobile)
before / (mobile)
after / (mobile)
after / (mobile)

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview
Route Before (production) After (this PR's preview)
/ before / (scroll)
before / (scroll)
after / (scroll)
after / (scroll)

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PaginationLink's aria-disabled has no visual/pointer-events effect, unlike sidebar.tsx's and calendar.tsx's aria-disabled: styling

1 participant