Skip to content

v4.0.42

Latest

Choose a tag to compare

@github-actions github-actions released this 20 Aug 23:58
· 2 commits to develop since this release

A send can no longer report success when the network refused it.

When you sent a transaction, the wallet asked the network to accept it and then reported success without ever checking the answer — the part of the code that reports a rejection was wired to nothing.

That mattered more than a missing error message. Because the wallet records a transaction as its own just before sending it, a transaction the network refused still marked the coins it spent as gone. The wallet was then holding coins that existed nowhere but on your phone, and anything sent afterwards could be built on them — and could never confirm.


What changed

  • Sends now report a rejection instead of silently reporting success, and a failed send is cleaned up rather than sitting in the send queue forever.
  • Clear stuck sends can now clear an orphaned transaction — one whose parent the wallet no longer has, which can never confirm. Previously the only cure was a full rebuild from chain. It errs on the side of caution: if it cannot read a transaction's origins it leaves it alone rather than removing something that might still be live.
  • Clearing a stuck send no longer strands the transactions built on top of it — the most likely way these orphans were created.
  • Apps and sites can hand the wallet a DigiAsset transfer request by link or QR. A malformed request is rejected outright, and the amount is shown and editable before you sign.

Found on a real wallet: an asset transfer sat "Pending" for eleven minutes, re-sent itself on restart, reported that six peers had relayed it, and existed in no mempool and no block anywhere.

Full notes: https://digiscope.me/wallet/releases/4.0.42


SHA-256: 9604ffb80f8600629396587030412b25a2c3755a538604f57a2afc923d2de1e8

Download from digiscope.me/downloads/ or install the APK below. Requires Android 8.0+.

Source: https://github.com/JohnnyLawDGB/digibytewallet-android