Skip to content

Conversation

@ViralBShah
Copy link
Member

@ViralBShah ViralBShah commented Nov 4, 2025

@mkitti @aviks I am forcing tests to run with 1 thread.

Given that tests pass, is it ok to register this version?

@ViralBShah ViralBShah merged commit 4662d6a into master Nov 4, 2025
5 checks passed
@aviks
Copy link
Collaborator

aviks commented Nov 4, 2025

Would be nice to update the README with the julia version compatibility.

@aviks
Copy link
Collaborator

aviks commented Nov 4, 2025

Actually, thinking about this a little more, now that we only test on 1.10 and above, should the Julia bounds in Project.toml be changed to reflect this?

@ViralBShah
Copy link
Member Author

ViralBShah commented Nov 4, 2025

We can still add back 1.6 in the tests - and that works fine I believe. Changing the julia version bound was problematic as it needed some changes on Taro.jl etc. but perhaps all of those are worth a quick refresh.

The right thing to do would be to add 1.6 as a julia version requirement and add min to the CI file to test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants