Mutating function in _solveLambdaNumeric cost #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1346 +/- ##
===========================================
+ Coverage 26.64% 74.48% +47.83%
===========================================
Files 68 68
Lines 4961 5012 +51
===========================================
+ Hits 1322 3733 +2411
+ Misses 3639 1279 -2360
Continue to review full report at Codecov.
|
Affie
commented
Aug 11, 2021
Comment on lines
+107
to
+116
| # # separate statements to try improve type-stability | ||
| # r = if islen1 | ||
| # Optim.optimize(cost, X0c, Optim.BFGS()) | ||
| # else | ||
| # Optim.optimize(cost, X0c, Optim.NelderMead()) | ||
| # end | ||
| alg = islen1 ? Optim.BFGS() : Optim.NelderMead() | ||
| X0 = hat(M, ϵ, X0c) | ||
| p0 = exp(M, ϵ, X0) | ||
| r = Optim.optimize(Xc->cost(p0, X0, Xc), X0c, alg) |
Member
Author
There was a problem hiding this comment.
I had a merge conflict that messed this up. I will incorporate the commented code. Although, I would just like to understand why it's a problem to improve in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.