Skip to content

Conversation

@Affie
Copy link
Member

@Affie Affie commented Aug 29, 2022

Basically the same test that fails in JuliaRobotics/RoME.jl#618

@Affie Affie added bug testing test all the things Test to improve coverage labels Aug 29, 2022
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1617 (5c1b6db) into master (f3864a5) will increase coverage by 19.54%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #1617       +/-   ##
===========================================
+ Coverage   56.56%   76.10%   +19.54%     
===========================================
  Files          73       73               
  Lines        5095     5424      +329     
===========================================
+ Hits         2882     4128     +1246     
+ Misses       2213     1296      -917     
Impacted Files Coverage Δ
src/services/EvalFactor.jl 84.45% <100.00%> (+9.17%) ⬆️
src/services/CompareUtils.jl 15.00% <0.00%> (-0.79%) ⬇️
src/NeedsResolution.jl 7.14% <0.00%> (-0.55%) ⬇️
src/Deprecated.jl 0.00% <0.00%> (ø)
src/ODE/DERelative.jl 100.00% <0.00%> (ø)
src/entities/CliqueTypes.jl 100.00% <0.00%> (ø)
src/RequireInteractiveUtils.jl 0.00% <0.00%> (ø)
src/ConsolidateParametricRelatives.jl 100.00% <0.00%> (ø)
src/Serialization/entities/AdditionalDensities.jl 100.00% <0.00%> (ø)
...Serialization/entities/SerializingDistributions.jl 100.00% <0.00%> (ø)
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Affie Affie added bug fix and removed bug labels Aug 29, 2022
@Affie Affie self-assigned this Aug 29, 2022
@Affie Affie added this to the v0.31.0 milestone Aug 29, 2022
Copy link
Member

@dehann dehann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for merge, thanks

@Affie Affie merged commit 7295259 into master Aug 29, 2022
@Affie Affie deleted the 22Q3/test/euclid_dist branch August 29, 2022 18:25
Affie added a commit that referenced this pull request Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants