[Git] Stop inlining binary literals in the per-commit diff - #38
Merged
Conversation
This was referenced Jul 26, 2026
DiffCommit/NumstatCommit passed --binary, which the branch-wide DiffAgainstBase never did. --binary is for producing appliable patches: it makes git inline a base85 "GIT binary patch" literal for every changed binary file. A 3KB blob expands to 123 lines; a few hundred KB is enough to exhaust the viewer's 20k-line cap and leave the preview pane showing nothing but base85. It also mis-colours: git's base85 alphabet includes + and -, so the diff body styler paints scattered literal lines as additions and deletions. Dropping the flag yields the usual one-line "Binary files a/x and b/x differ", matching DiffAgainstBase. The numstat path is unaffected — it already reported binary files as Binary with zero counts, so the file index still renders them as "binary". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> ct-stack-id: 7e62f7d8
KCaverly
force-pushed
the
ct/diff_view/7e62f7d8
branch
from
July 26, 2026 19:23
de84f37 to
228e192
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffCommit/NumstatCommit passed --binary, which the branch-wide
DiffAgainstBase never did. --binary is for producing appliable patches: it
makes git inline a base85 "GIT binary patch" literal for every changed
binary file. A 3KB blob expands to 123 lines; a few hundred KB is enough to
exhaust the viewer's 20k-line cap and leave the preview pane showing
nothing but base85.
It also mis-colours: git's base85 alphabet includes + and -, so the diff
body styler paints scattered literal lines as additions and deletions.
Dropping the flag yields the usual one-line "Binary files a/x and b/x
differ", matching DiffAgainstBase. The numstat path is unaffected — it
already reported binary files as Binary with zero counts, so the file index
still renders them as "binary".
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Stack (bottom → top):