Skip to content

[UI] Give d the preview and esc the way out - #44

Merged
KCaverly merged 1 commit into
mainfrom
ct/diff_view/6f071f3e
Jul 26, 2026
Merged

[UI] Give d the preview and esc the way out#44
KCaverly merged 1 commit into
mainfrom
ct/diff_view/6f071f3e

Conversation

@KCaverly

@KCaverly KCaverly commented Jul 26, 2026

Copy link
Copy Markdown
Owner

esc was doing two jobs on the stack screen. With the preview open it closed
the preview; with it shut it closed the screen. So leaving cost one keypress
or two depending on a mode you had to remember you were in, and d — the key
that opened the preview — shared the first job with it.

Now each key means one thing. d toggles the preview, open and shut, from
either pane. esc leaves the stack screen from anywhere and hands back
whatever was underneath.

The return itself already worked: the stack screen is an overlay and never
owned m.screen, so dropping it has always revealed the screen it was opened
over. What was wrong was the footer calling that "deck", which is only true
when the deck is what opened it — open the screen from the palette while on
the agent screen and esc has always gone back there. The hint now says
"return", which is true from every entry point, and the text-window footer
matches.

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com


Stack (bottom → top):

  1. [UI] Give d the preview and esc the way out #44 ← this PR
  2. [UI] Drop the branch-diff jump from the stack screen #45
  3. [UI] Stop the stack preview overrunning a narrow terminal #46
  4. [Git] Pin the diff flags the body parser depends on #47
  5. [UI] Teach both diff viewers the same file-jump key #48
  6. [Diff] Thread the [diff] config through the viewer and zoom with z #49
  7. [Git] Carry diff args and excludes through every diff call #50
  8. [Diff] Add the external diff pager package #51
  9. [Config] Accept a [diff] section with an optional pager #52
  10. [Docs] Document the diff viewer settings #53

@KCaverly
KCaverly force-pushed the ct/diff_view/65d117c2 branch from 515d911 to f41c87b Compare July 26, 2026 19:23
@KCaverly
KCaverly force-pushed the ct/diff_view/6f071f3e branch from 3a13849 to b93e42d Compare July 26, 2026 19:23
@KCaverly
KCaverly force-pushed the ct/diff_view/65d117c2 branch from f41c87b to 147876f Compare July 26, 2026 19:30
@KCaverly
KCaverly force-pushed the ct/diff_view/6f071f3e branch from b93e42d to ae0bcc6 Compare July 26, 2026 19:30
@KCaverly
KCaverly force-pushed the ct/diff_view/65d117c2 branch from 147876f to e81c3d2 Compare July 26, 2026 19:34
@KCaverly
KCaverly force-pushed the ct/diff_view/6f071f3e branch from ae0bcc6 to 50d758f Compare July 26, 2026 19:34
Base automatically changed from ct/diff_view/65d117c2 to main July 26, 2026 19:35
esc was doing two jobs on the stack screen. With the preview open it closed
the preview; with it shut it closed the screen. So leaving cost one keypress
or two depending on a mode you had to remember you were in, and d — the key
that opened the preview — shared the first job with it.

Now each key means one thing. d toggles the preview, open and shut, from
either pane. esc leaves the stack screen from anywhere and hands back
whatever was underneath.

The return itself already worked: the stack screen is an overlay and never
owned m.screen, so dropping it has always revealed the screen it was opened
over. What was wrong was the footer calling that "deck", which is only true
when the deck is what opened it — open the screen from the palette while on
the agent screen and esc has always gone back there. The hint now says
"return", which is true from every entry point, and the text-window footer
matches.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ct-stack-id: 6f071f3e
@KCaverly
KCaverly force-pushed the ct/diff_view/6f071f3e branch from 50d758f to 520c850 Compare July 26, 2026 19:39
@KCaverly
KCaverly merged commit 3972ae2 into main Jul 26, 2026
2 checks passed
@KCaverly
KCaverly deleted the ct/diff_view/6f071f3e branch July 26, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant