[pull] main from microsoft:main #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
joh/defiant wallaby
* Transform ext host log URI on remote side * Fix mistype
* Allow action labels to be long in comment header Part of #164288 * Better fix
Do not interrupt if there are no affected cells
Fixes #164131: Do not adjust y offset when the mouse is below the last line
* tunnel --name should rename old tunnel * fix clippy warning
Includes a few more fixes for link update on rename
better error message
…heckbox Add accessibility role type to the checkbox in getting started step
…165505) Update role and aria-label for the Hide button
Co-authored-by: gcb4 <gcb4@sfu.ca>
* panel and auxiliar bar part css refs #165169 * unused imports
…165565) Fixes microsoft/vscode-internalbacklog#3161 It's wild to me that we only allowed this on web originally. This should get rid of quite a few dialogs on Desktop.
* Try passing offset to editors on layout When a notebook editor is created, it currently has to force a relayout to determine where the overlay webview should be positioned. We do this with a call to `getBoundingClientRect` However the grid view should already have information about where the editor is positioned. If we can use this, then we can skip the expensive call to `getBoundingClientRect` entirely This change attempts to pass the `top` and `left` offsets to the `EditorGroupView` and eventually down into `NotebookEditorWidget` The PR does not work properly however as the offset that the `EditorGroupView` gets is wrong. I've added some todo comments about where this seems to be happening * Remove todo and update layout over
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )