guard known-driver suffix compare in windows_get_registry_files#1980
Conversation
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
1 similar comment
|
Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build. |
|
CI Vulkan-Loader build queued with queue ID 48151. |
|
CI Vulkan-Loader build # 3646 running. |
|
There seems to be some issue with the macOS CI tests. I tried to reproduce it locally but after 2 hours couldn't. I fear it is something specific to the runner environment that I couldn't determine. Regardless, the crash seems to have showed up in 9512907 as the build runs ctest to query the available tests. But that is my suspicion, not a proven statement. |
|
CI Vulkan-Loader build # 3646 passed. |
|
Its an upstream CMake issue. I'm going to ignore it because it'll likely be fixed in the next CMake release that gets picked up by the github actions runner. |
|
thanks for merging this, and for chasing the macOS CI noise down to the upstream CMake issue. |
|
thanks for chasing down that CI flake and merging this |
windows_get_registry_files matches the tail of each registry driver name against the known-driver table via name + strlen(name) - strlen(filename), which points before the name buffer when a registry name is shorter than the filename, so the tail compare now runs only when the name is at least as long as the filename.