Skip to content

guard known-driver suffix compare in windows_get_registry_files#1980

Merged
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
aizu-m:registry-known-driver-suffix-bounds
Jul 20, 2026
Merged

guard known-driver suffix compare in windows_get_registry_files#1980
charles-lunarg merged 1 commit into
KhronosGroup:mainfrom
aizu-m:registry-known-driver-suffix-bounds

Conversation

@aizu-m

@aizu-m aizu-m commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

windows_get_registry_files matches the tail of each registry driver name against the known-driver table via name + strlen(name) - strlen(filename), which points before the name buffer when a registry name is shorter than the filename, so the tail compare now runs only when the name is at least as long as the filename.

@ci-tester-lunarg

Copy link
Copy Markdown

Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build.

1 similar comment
@ci-tester-lunarg

Copy link
Copy Markdown

Author aizu-m not on autobuild list. Waiting for curator authorization before starting CI build.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build queued with queue ID 48151.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3646 running.

@charles-lunarg

Copy link
Copy Markdown
Collaborator

There seems to be some issue with the macOS CI tests. I tried to reproduce it locally but after 2 hours couldn't. I fear it is something specific to the runner environment that I couldn't determine. Regardless, the crash seems to have showed up in 9512907 as the build runs ctest to query the available tests. But that is my suspicion, not a proven statement.

@ci-tester-lunarg

Copy link
Copy Markdown

CI Vulkan-Loader build # 3646 passed.

@charles-lunarg

charles-lunarg commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Its an upstream CMake issue.
https://gitlab.kitware.com/cmake/cmake/-/work_items/27972 Edit: similar but not the most closely matching issue. That would be https://gitlab.kitware.com/cmake/cmake/-/work_items/27939

I'm going to ignore it because it'll likely be fixed in the next CMake release that gets picked up by the github actions runner.

@charles-lunarg
charles-lunarg merged commit b9057a2 into KhronosGroup:main Jul 20, 2026
49 of 51 checks passed
@aizu-m

aizu-m commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

thanks for merging this, and for chasing the macOS CI noise down to the upstream CMake issue.

@aizu-m

aizu-m commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

thanks for chasing down that CI flake and merging this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants