codegen: Don't hide import error message from Python - #1995
Merged
charles-lunarg merged 1 commit intoAug 4, 2026
Merged
Conversation
`from reg import Registry` could fail for reasons other than not having Vulkan-Headers' `registry/` directory on `sys.path`. For example, if the `pyparsing` module dependency isn't installed, then importing `reg` will also fail as a result. Show Python's error message to the user so that they can correct any missing dependencies. Signed-off-by: Simon McVittie <smcv@collabora.com>
|
CI Vulkan-Loader build queued with queue ID 65048. |
|
CI Vulkan-Loader build queued with queue ID 65065. |
|
CI Vulkan-Loader build # 3674 running. |
|
CI Vulkan-Loader build # 3674 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from reg import Registrycould fail for reasons other than not having Vulkan-Headers'registry/directory onsys.path. For example, if thepyparsingmodule dependency isn't installed, then importingregwill also fail as a result.Show Python's error message to the user so that they can correct any missing dependencies.