Remove accidental declaration of buffer block in multi_draw_indirect#1456
Merged
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom Jan 8, 2026
Merged
Remove accidental declaration of buffer block in multi_draw_indirect#1456marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom
marty-johnson59 merged 2 commits intoKhronosGroup:mainfrom
Conversation
Giving an instance name to a buffer_reference declaration also declares a block with that type, which does not seem to have been the intention.
e4d9de8 to
b7ccfd3
Compare
Contributor
|
The copyright message should look like this now: Besides that: looks good. |
gnl21
commented
Dec 16, 2025
Contributor
Author
Done, thanks. |
gpx1000
approved these changes
Dec 16, 2025
Collaborator
gpx1000
left a comment
There was a problem hiding this comment.
LGTM; thanks for fixing this.
SaschaWillems
approved these changes
Dec 16, 2025
asuessenbach
approved these changes
Dec 17, 2025
Contributor
|
Merging - 3 approvals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Giving an instance name to a buffer_reference declaration also declares a block with that type, which does not seem to have been the intention. The block is never given a binding (which should not be valid, but see KhronosGroup/glslang#4128) and is never used in the shader, so remove the declaration. There should be no functional change to the sample (verified on Broadcom's implementation).
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: