Rework synchronization in api based samples#1527
Draft
SaschaWillems wants to merge 12 commits intoKhronosGroup:mainfrom
Draft
Rework synchronization in api based samples#1527SaschaWillems wants to merge 12 commits intoKhronosGroup:mainfrom
SaschaWillems wants to merge 12 commits intoKhronosGroup:mainfrom
Conversation
Locked behind a setting until all samples have been updated
Locked behind a setting until all samples have been updated
Locked behind a setting until all samples have been updated
Locked behind a setting until all samples have been updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks how CPU/GPU sync works in the samples based on my (low-level) framework. Those sample still to a device wait idle after each frame, killing any chance of GPU/GPU parallelism.
This PR aims to fix that by introducing proper support for multiple frames-in-flight. The changes will mirror what I did for my samples last year: https://www.saschawillems.de/blog/2025/08/15/fundamental-vulkan-samples-rework/
Note: This is a draft, the PR currently mostly exists for me to track progress on this.
Fixes #1380
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batchcommand line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: