-
Notifications
You must be signed in to change notification settings - Fork 685
Add new conformance test for index validation with large attribute buffe... #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Link to live version of this test: http://jareiko.github.com/webgl-conformance/conformance/buffers/index-validation-large-buffer.html |
|
I agree that the presented test code should not generate an error. Test passes on my machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things:
- can you add "--min-version 1.0.2 " in front of this line?
- this is the wrong file to edit. We only allow editing of sdk/tests/conformance so in this case this file needs to be in
sdk/tests/conformance/buffers/00_test_list.txt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things:
- Do you mind changing this to the WebGL license?
- this is the wrong place for this file. We only allow editing in sdk/tests/conformance so this needs to be
sdk/tests/conformance/buffers/index-validation-large-buffer.html
|
Thanks for this. There's a couple of changes I added comments. If you don't mind making the changes that would be great. Otherwise I can make them and merge it myself. It's up to you. |
|
PTAL :) |
Add new conformance test for index validation with large attribute buffe...
Add a test for index verification when a large attribute buffer is bound.
This currently fails in Firefox 18.0 beta OSX.