Skip to content

Conversation

@jareiko
Copy link
Contributor

@jareiko jareiko commented Dec 28, 2012

Add a test for index verification when a large attribute buffer is bound.

This currently fails in Firefox 18.0 beta OSX.

@jareiko
Copy link
Contributor Author

jareiko commented Dec 28, 2012

@pyalot
Copy link
Contributor

pyalot commented Dec 28, 2012

I agree that the presented test code should not generate an error.

Test passes on my machine
google-chrome --version --> Google Chrome 23.0.1271.97
firefox --version --> Mozilla Firefox 17.0.1
lsb_release -a --> Description: Ubuntu 12.04.1 LTS
uname -a --> 3.2.0-34-generic-pae
cat /proc/driver/nvidia/version --> NVIDIA UNIX x86 Kernel Module 304.64
lspci -v | grep -i vga --> NVIDIA Corporation GF104 [GeForce GTX 460]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  1. can you add "--min-version 1.0.2 " in front of this line?
  2. this is the wrong file to edit. We only allow editing of sdk/tests/conformance so in this case this file needs to be in

sdk/tests/conformance/buffers/00_test_list.txt

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  1. Do you mind changing this to the WebGL license?
  2. this is the wrong place for this file. We only allow editing in sdk/tests/conformance so this needs to be
    sdk/tests/conformance/buffers/index-validation-large-buffer.html

@greggman
Copy link
Contributor

Thanks for this. There's a couple of changes I added comments. If you don't mind making the changes that would be great. Otherwise I can make them and merge it myself. It's up to you.

@jareiko
Copy link
Contributor Author

jareiko commented Dec 28, 2012

PTAL :)

greggman added a commit that referenced this pull request Dec 28, 2012
Add new conformance test for index validation with large attribute buffe...
@greggman greggman merged commit 1c0cc4d into KhronosGroup:master Dec 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants