Fix bug when blitting pixels outside read framebuffer#2086
Merged
zhenyao merged 1 commit intoKhronosGroup:masterfrom Oct 10, 2016
Merged
Fix bug when blitting pixels outside read framebuffer#2086zhenyao merged 1 commit intoKhronosGroup:masterfrom
zhenyao merged 1 commit intoKhronosGroup:masterfrom
Conversation
Contributor
|
LGTM. |
Contributor
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After holiday, I carefully revisited the behavior of blitting from pixels outside read framebuffer TO PIXELS OUTSIDE OF DRAW FRAMEBUFFER, I found that I misunderstand the behavior suggested in this issue: https://cvs.khronos.org/bugzilla/show_bug.cgi?id=3576. The out-of-bounds pixels in dst region should be considered for scaling during blitting, although these outofbounds pixels in dst region will not be drew. But they should not be ignored.
This small pr will correct the behavior.
After this revision applied, this test can pass in Linux and Windows (But still fail on MacOSX as expected). PTAL. @zhenyao and @kenrussell .