Add tests for WebGL2 non-POT texture support.#743
Merged
Conversation
Member
|
@toji could you please review this and provide guidance about how to exclude the old NPOT texture tests when running on WebGL 2.0? Thanks. |
Member
|
To exclude a test from the 2.0 set, add a Otherwise the test looks good. Please add the flag described about and address the comment about the date and I'll merge it. |
Contributor
Author
|
Thanks, that worked! Updated copyright year & added exclusion. |
toji
added a commit
that referenced
this pull request
Oct 10, 2014
Add tests for WebGL2 non-POT texture support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the WebGL1 texture-npot test with some changes to check that the non-power-of-two texture size operations pass on WebGL2. Of course the original texture-npot tests will fail when run in a WebGL2 context, but I wasn't sure if there was a way to exclude just that test.