Skip to content

Add tests for WebGL2 non-POT texture support.#743

Merged
toji merged 2 commits into
KhronosGroup:masterfrom
dvander:webgl2-non-pot
Oct 10, 2014
Merged

Add tests for WebGL2 non-POT texture support.#743
toji merged 2 commits into
KhronosGroup:masterfrom
dvander:webgl2-non-pot

Conversation

@dvander
Copy link
Copy Markdown
Contributor

@dvander dvander commented Oct 9, 2014

This is the WebGL1 texture-npot test with some changes to check that the non-power-of-two texture size operations pass on WebGL2. Of course the original texture-npot tests will fail when run in a WebGL2 context, but I wasn't sure if there was a way to exclude just that test.

@kenrussell
Copy link
Copy Markdown
Member

@toji could you please review this and provide guidance about how to exclude the old NPOT texture tests when running on WebGL 2.0? Thanks.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update date to 2014, please.

@toji
Copy link
Copy Markdown
Member

toji commented Oct 10, 2014

To exclude a test from the 2.0 set, add a --max-version 1.9.9 to the 00_test_list.txt entry for the test. See https://github.com/KhronosGroup/WebGL/blob/master/sdk/tests/conformance/context/00_test_list.txt#L1 for an example.

Otherwise the test looks good. Please add the flag described about and address the comment about the date and I'll merge it.

@dvander
Copy link
Copy Markdown
Contributor Author

dvander commented Oct 10, 2014

Thanks, that worked! Updated copyright year & added exclusion.

toji added a commit that referenced this pull request Oct 10, 2014
Add tests for WebGL2 non-POT texture support.
@toji toji merged commit 4f45355 into KhronosGroup:master Oct 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants