Fix tex-new-formats to reflect WebGL2 sRGB semantics#745
Merged
Conversation
…rent from WebGL1 with EXT_sRGB
bjacob
added a commit
that referenced
this pull request
Oct 10, 2014
Fix tex-new-formats to reflect WebGL2 sRGB semantics
Member
|
Good catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't realize this when I wrote this test, but this is a substantial difference between WebGL2 (i.e. ES 3) and the old EXT_sRGB. In WebGL2 / ES3, there is not even a SRGB_ALPHA constant. Instead, people are expected to use RGB and RGBA for format. In other words, WebGL2 / ES3 does not have 1:1 mapping between sized formats, and (unsized format, type) pairs. The (RGBA, UNSIGNED_BYTE) pair corresponds to both plain old RGBA8, and to SRGB8_ALPHA8.