Some funcs should return null on error. #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were expected to return the empty string previously. The spec requires returning null, though.
Member
|
Thanks for the fix. You're right, this is a longstanding bug, and yes, we'll have to backport the fix to earlier releases of the conformance suite. Merging this now and will discuss backporting it with the other vendors on the next conference call. |
kenrussell
added a commit
that referenced
this pull request
Dec 10, 2014
Some funcs should return null on error.
kenrussell
added a commit
to kenrussell/WebGL
that referenced
this pull request
Dec 13, 2014
…mance suite snapshots.
toji
added a commit
that referenced
this pull request
Dec 15, 2014
…lues Backport bug fix from pull request #803 to earlier conformance suite sna...
marcorperez
pushed a commit
to Mobica/WebGL-dev
that referenced
this pull request
May 12, 2015
…mance suite snapshots.
marcorperez
pushed a commit
to Mobica/WebGL-dev
that referenced
this pull request
May 12, 2015
…mance suite snapshots.
marcorperez
pushed a commit
to Mobica/WebGL-dev
that referenced
this pull request
May 12, 2015
…mance suite snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were expected to return the empty string previously. The spec
requires returning null, though.
We might want to backport this to previous snapshots, but I only fix trunk here.