This repository was archived by the owner on Dec 22, 2023. It is now read-only.
Conversation
Member
|
|
Member
|
Oh it is fixed, it just wasn't obvious from the way GitHub shows diffs. |
Member
|
This all looks good, except Travis is broken/hung/slow throughout most of the Khronos repos, so we don't have a CI result. |
Contributor
|
/cc #282 |
…y/glTF-Sample-Models into upgrade-ci # Conflicts: # .travis.yml
Member
|
I merged @donmccurdy's #282 in here, so we could see the new CI run. It appears to have run twice for the same commit, once for "push" and once for "pull_request". The latter finished in 54 seconds, but the "push" one is still trying to clone the repo, several minutes later. Is that a fluke? Should we only allow one build? |
Member
|
Well it passed, after 18 minutes. We can fine-tune in a follow-up PR. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.