feat(code-reviews): support REVIEW.md#3183
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental ReviewReviewed changes since commit Changes reviewed in incremental diff:
All previous resolutions confirmed still in place. No new issues found. Files Reviewed (23 files)
Reviewed by claude-sonnet-4.6 · 3,275,668 tokens |
# Conflicts: # apps/web/src/lib/code-reviews/triggers/prepare-review-payload.test.ts # apps/web/src/lib/code-reviews/triggers/prepare-review-payload.ts
|
Manual test passed. Tested:
Verified:
|
| selected_repository_ids: z.array(z.number()).optional(), | ||
| // Manually added repositories (for GitLab where pagination limits results) | ||
| manually_added_repositories: z.array(ManuallyAddedRepositorySchema).optional(), | ||
| disable_review_md: z.boolean().optional(), |
There was a problem hiding this comment.
nit; It's just a little bit wonky that the field name is for controlling this feature is phrased as the negative (i.e. disable review.md?) rather than the positive review_md_enabled. Might consider adding a default value to the zod schema as well so undefined's don't need to be considered
There was a problem hiding this comment.
I'll address it in a followup PR prob next in which I enable by default REVIEW.md for all orgs
Orgs still need to add the REVIEW.md file
Summary
REVIEW.mdguidance in code review prompts and record when that guidance is used.REVIEW.mddisabled by default through the DB-backeddisable_review_mdsetting so the feature can be enabled selectively during testing.disable_review_md: falseenables repository guidance.Verification
N/A - no manual verification was performed for this backend default change.
Visual Changes
N/A
Reviewer Notes
The default-off behavior is intended as a short-lived rollout flag. Existing configs with
disable_review_mdmissing now skip repositoryREVIEW.md; explicitly setting it tofalseenables the feature.