feat(gastown+web): slingExistingPr + BeadPanel babysit badge (chunks 0+4)#3539
Closed
jrf0110 wants to merge 6 commits into
Conversation
added 5 commits
May 27, 2026 17:13
…emove unused imports and redundant casts
…ePushAllowed tests - Extract eventDescription from ActivityFeed.tsx to pure event-description.ts to avoid motion/react transitive import in Jest test - Re-export from ActivityFeed.tsx for backwards compatibility - Update babysit-ui.test.ts to import from event-description.ts - Replace trivial forcePushAllowed inline tests with tests exercising submitExternalPrToReviewQueue through MiniSql mock - Enhance MiniSql mock to capture INSERT statements and params
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryAll 5 issues from the previous review have been addressed in commit Previously Reported Issues — All Resolved
Files Reviewed (6 files, incremental)
Reviewed by claude-4.6-sonnet-20260217 · 1,006,657 tokens Review guidance: REVIEW.md from base branch |
…ab, remove chunk-1 leak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements chunks 0 and 4 of the "Babysit existing PR" feature:
Chunk 0 — Town DO slingExistingPr method + review-queue refactor:
submitToReviewQueueto extractcreateMergeRequestBeadCoreprivate helper (public signature unchanged, no caller changes)submitExternalPrToReviewQueuefunction that createsmerge_request+review_metadatarows withgt:babysitlabel, notracksedge, andbabysit_startedactivity eventTown.do.ts::slingExistingPrmethod with repo validation, open-state check, PR metadata fetch, and title/body defaultscheckPRStatusreturn shape withhead_branch,base_branch,head_sha,title(existing callers unchanged)parsePrUrlForRepoMatchutility for repo-match validationChunk 4 — BeadPanel babysit badge + metadata surfacing:
gt:babysitlabel presenteventDescriptionto separate module for testabilitybabysit_started,pr_feedback_detected,pr_conflict_detected,pr_auto_merge,pr_status_changedbabysit_startedevent type to bead-events tableVerification
pnpm --filter cloudflare-gastown test— all 19 new unit tests passbabysit-ui.test.ts— 9 event description tests pass (imports from extractedevent-description.ts, no runtime component import)gt:babysitlabeled beadsVisual Changes
BeadPanel now shows "Babysat external PR" badge, head SHA, and force-push status for babysat beads. Event timeline renders babysit-specific event types with appropriate icons and descriptions.
Reviewer Notes
createMergeRequestBeadCorerefactor is intentionally minimal — single private helper, public API unchangedcheckPRStatusextension is backward-compatible: new fields are optional