Improve Agents session list feedback

[iscekic]

What

• Adds immediate search activity feedback, row navigation protection, and a bottom-right New session button in Agents.
• Shows optional live total cost on Active now rows.

Why

• Makes typed searches visibly responsive, prevents duplicate session navigation, and exposes current active-session spend.

How

• Uses separate debounce/fetch busy selectors, a focus-reset navigation lock, and the existing local FAB layout pattern.
• Keeps raw search text outside React state, so the busy state changes only on edges while backspacing to the committed query clears it immediately.
• Extends active-session enrichment with an optional cost field, preserves that cost across WebSocket merges, and keeps needs-input precedence.

Verification

• pnpm typecheck && pnpm lint && pnpm check:unused && pnpm test from apps/mobile/ passed: 2,616 tests before the focused post-review repairs.
• Focused post-review repairs ran mobile search-state/selector tests plus pnpm typecheck && pnpm lint.
• pnpm test:db then JEST_MAX_WORKERS=1 pnpm --filter web test -- active-sessions-router passed: 62 tests.
• Kilobot approved the current head with No Issues Found | Recommendation: Merge.
• Current-head CI is blocked by an unrelated apps/web model-experiment partition test: the test job failed twice with no partition of relation "model_experiment_request" found for row. The section does not touch that router, its tests, or database partitioning.
• Full local pnpm validate typecheck/lint passed; full web Jest collided with local per-worker PostgreSQL setup. Targeted router coverage passed after database recovery.

E2E status

• Final iOS verifier passed all mandatory runtime cases on a real kilo/kilo-auto/efficient remote CLI session: search pending/clear, row double-tap/re-arm, FAB navigation, and live formatted cost.
• Focused iOS re-verification on the latest search-hook repair passed: abcd showed Searching…, immediate backspace to committed abc removed it, and Clear X restored the list with no busy indicator.
• The optional needs-input foreground-banner smoke is skipped: iOS simulator notification banner capture is unavailable. Existing unit coverage and the item-6 evidence below cover its deterministic behavior.
• Every stack, simulator, recorder, remote CLI, and E2E slot started by this section was stopped/released after each verifier sentinel.

Item 6 verification

• Existing foreground notification behavior already meets the requirement:
  • services/session-ingest/src/remote-session-notifications.ts:109
  • services/cloud-agent-next/src/websocket/ingest-attention-classifier.ts:150
  • services/notifications/src/lib/cloud-agent-session-push.ts:146-150
  • apps/mobile/src/components/agents/session-detail-content.tsx:53,208
  • apps/mobile/src/components/kilo-chat/hooks/use-cli-session-presence.ts:13-19
  • apps/mobile/src/lib/notifications.ts:57-73

Visual Changes

• Search pending / backspace verification:
  
• New-session FAB verification:
  

[iscekic]

(bot) E2E is blocked: the three iOS verifier rounds did not produce reliable runtime evidence. All E2E resources have been released; details are in the PR description.

[kilo-code-bot]

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of e3ffe8b5d..1a0c74c4b found no PR-authored code changes: the range contains only a clean merge of origin/main and an empty retrigger commit, and the previously reviewed mobile/web files are byte-identical to the last reviewed state.

Files Reviewed (0 PR-authored changes in range)

• No PR-authored files changed since e3ffe8b5d.
• Verified unchanged since the previous review: apps/mobile/src/components/agents/*, apps/mobile/src/lib/active-sessions-live.ts, apps/mobile/src/lib/hooks/use-agent-sessions.ts, apps/web/src/routers/active-sessions-router.ts and its tests.

Incremental scope verification (click to expand)

• Range commits: f35cc4a43 (merge of origin/main) and 1a0c74c4b (empty chore: retrigger kilobot review).
• Merge was clean: the combined-diff (--cc) for f35cc4a43 is empty, so no conflict-resolution edits were introduced by the merge.
• Inherited-from-main files (apps/web/src/app/admin/**, apps/web/src/lib/cloudflare/**, packages/db/src/migrations/**, services/cloud-agent-next/**, apps/extension/package.json, apps/mobile/e2e/record.sh) match b9ebddce3 exactly and belong to already-merged PRs chore(extension): bump version to 0.1.3 #4933, feat(admin): add container metrics to session traces #4935, fix(ci): August model_experiment partitions and record.sh adb #4949; they are out of scope for this PR review.
• Spot re-verification at HEAD: use-session-search-input.ts:109 still uses the bidirectional identity-preserving updater, and all clear paths (:84, :131) plus the commitSearchQuery wrapper (:66) still force awaitingCommit to false, so the previously resolved busy-indicator finding remains fixed.

Assumptions

• Prior findings on files unchanged in this range are not carried forward: two are outdated on the remote (line: null) after author fixes, and three were explicitly rejected with rationale by the author.
• No tests were executed; conclusions come from reading code and git history at 1a0c74c4b.

Previous Review Summaries (3 snapshots, latest commit e3ffe8b)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit e3ffe8b)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental review of e3ffe8b5d (one changed line in use-session-search-input.ts): the awaitingCommit updater is now bidirectional, which resolves the only outstanding finding, and no new defects were found in the changed code.

Files Reviewed (1 file)

• apps/mobile/src/components/agents/use-session-search-input.ts

Resolved since the previous review

• One-way busy flag (previous SUGGESTION). setAwaitingCommit(prev => (prev === shouldAwait ? prev : shouldAwait)) now allows both false→true and true→false, so backspacing back to the committed query inside the 300ms debounce window hides Searching… immediately. The identity-return keeps the keystroke-level render bailout that motivated the functional updater, so the earlier re-render fix is preserved.

Verified clean in the changed code (click to expand)

• Transition correctness. selectAwaitingCommit compares text.trim() against searchQueryRef.current, so the updater's target value is a pure function of the current keystroke and the last committed query; the ternary cannot desynchronize it from that derived value.
• No stuck indicator. Every clear path (handleClearSearchOnly, clearSearchInput) and the commitSearchQuery wrapper still force setAwaitingCommit(false), and scheduleSearch always schedules a commit, so the flag remains bounded by SEARCH_DEBOUNCE_MS.
• No stale-commit race. A pending commit for the same text landing after a backspace-induced false only re-applies setSearchQuery(query) and setAwaitingCommit(false), which is idempotent.
• Comment accuracy. The updated block correctly describes both allowed transitions and no longer claims the true→true no-op is one-way.

Assumptions

• Incremental scope only: 15936839d..e3ffe8b5d. Previous findings on files unchanged in this range were verified as outdated on the remote (GitHub reports line: null) or explicitly rejected/answered by the author, and are not carried forward.
• Tests were not executed; conclusions come from reading code at e3ffe8b5d.

Previous review (commit 1593683)

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Incremental review of the two follow-up commits: the re-render fix in use-session-search-input.ts works, but the new prev || shouldAwait updater makes awaitingCommit one-way, so the Searching… row lingers for the debounce window after the user backspaces the field.

Overview

Severity	Count
CRITICAL	0
WARNING	0
SUGGESTION	1

Issue Details (click to expand)

SUGGESTION

File	Line	Issue
apps/mobile/src/components/agents/use-session-search-input.ts	108	`setAwaitingCommit(prev => prev

Files Reviewed (2 files)

• apps/mobile/src/components/agents/use-session-search-input.ts - 1 issue
• apps/mobile/src/components/agents/session-list-search-busy.test.ts - 0 issues

Resolved since the previous review

• Per-keystroke re-renders (previous WARNING). Raw typed text now lives in lastTypedRef, and only the derived boolean reaches state, so the SectionList no longer re-renders on every keystroke.
• Duplicate selectShowSearchBusy cases (previous SUGGESTION). The three redundant assertions were removed; the four remaining cases are distinct input tuples.

Verified clean in the changed code (click to expand)

• Busy flag lifecycle. Every clear path (handleClearSearchInput, clearSearchInput, clearSearchOnly, clearBroadly) reaches setAwaitingCommit(false), and scheduleSearch always schedules a commit, so the flag cannot stick permanently — the worst case is bounded by SEARCH_DEBOUNCE_MS.
• Commit wrapper. Wrapping commitSearchQuery keeps setSearchQuery and the busy reset in one batch; scheduleSearch cancels the prior handle, so a stale commit cannot land after a newer keystroke.
• searchQueryRef staleness. The ref is written during render from the state being rendered, matching the existing use-pr-diff-context-loader.ts pattern; the value read in handleSearchInputChange matches the last committed query in all realistic orderings.
• Trim parity. selectAwaitingCommit still compares lastTyped.trim() with the committed query, so trailing whitespace does not stick the indicator.

Assumptions

• Incremental scope only: 0a0b74e2f..15936839d. Findings on unchanged files from the previous review were not carried forward.
• Tests were not executed; conclusions come from reading code at 15936839d.

Fix these issues in Kilo Cloud

Previous review (commit 0a0b74e)

Status: 5 Issues Found | Recommendation: Address before merge

Executive Summary

Highest risk is a per-keystroke re-render of the whole Agents session list introduced by storing raw search text in React state (use-session-search-input.ts), plus a navigation lock whose only re-arm point is screen focus.

Overview

Severity	Count
CRITICAL	0
WARNING	2
SUGGESTION	3

Issue Details (click to expand)

WARNING

File	Line	Issue
apps/mobile/src/components/agents/use-session-search-input.ts	74	setLastTyped(text) puts raw typed text in state, so the screen and the SectionList re-render on every keystroke (previously setHasText bailed out); only the derived boolean is needed
apps/mobile/src/components/agents/session-list-screen.tsx	119	rowNavLockRef only re-arms on focus and the catch covers synchronous throws only, so a push that fails otherwise leaves all history and tray rows silently inert; both new-session pushes remain unguarded

SUGGESTION

File	Line	Issue
apps/mobile/src/components/agents/session-list-screen.tsx	266	FAB duplicates the header + with an identical New session accessibility label and the same visibility condition
apps/mobile/src/components/agents/use-agent-session-list-data.ts	80	useCallback deps use the whole search object (new identity each render) instead of the stable search.refetch, defeating memoization the pre-refactor code intentionally had
apps/mobile/src/components/agents/session-list-search-busy.test.ts	55	Five of eight selectShowSearchBusy cases assert only two distinct input tuples; the real uncovered boundary is { awaitingCommit: false, isSearching: true, isFetching: false }

Files Reviewed (17 files)

• apps/mobile/src/components/agents/remote-session-row.tsx - 0 issues
• apps/mobile/src/components/agents/session-list-content.tsx - 0 issues
• apps/mobile/src/components/agents/session-list-helpers.test.ts - 0 issues
• apps/mobile/src/components/agents/session-list-helpers.ts - 0 issues
• apps/mobile/src/components/agents/session-list-screen.tsx - 2 issues
• apps/mobile/src/components/agents/session-list-search-busy.test.ts - 1 issue
• apps/mobile/src/components/agents/session-list-search-busy.ts - 0 issues
• apps/mobile/src/components/agents/session-list-search-header.tsx - 0 issues
• apps/mobile/src/components/agents/use-agent-session-list-data.ts - 1 issue
• apps/mobile/src/components/agents/use-session-search-input.ts - 1 issue
• apps/mobile/src/lib/active-sessions-live.merge.test.ts - 0 issues
• apps/mobile/src/lib/active-sessions-live.ts - 0 issues
• apps/mobile/src/lib/hooks/use-agent-sessions.ts - 0 issues
• apps/web/src/routers/active-sessions-router.cloud.test.ts - 0 issues
• apps/web/src/routers/active-sessions-router.list.test.ts - 0 issues
• apps/web/src/routers/active-sessions-router.schema.test.ts - 0 issues
• apps/web/src/routers/active-sessions-router.ts - 0 issues

Verified clean (click to expand)

• Cost enrichment (server). Both cli_sessions_v2 selects are scoped by kilo_user_id, and the org-filtered path still runs ensureOrganizationAccess, so no tenancy widening. bigint({ mode: 'number' }) makes z.number() the correct wire type, and the != null guards keep null off the wire while preserving a legitimate 0.
• Cost stickiness (client). readEnrichment is keyed by session id, the ingest writer is monotonic (SessionIngestDO.persistLiveSessionColumns), and polls replace the array wholesale, so a preserved cached cost can only be a lower bound, never a wrong higher number. The typeof === 'number' guard is consistent with the other sticky fields and correctly unlike organizationId.
• Visible vs spoken meta. selectSessionRowEyebrowRight returns needs-input before meta is rendered, so suppressing spoken cost/time under needsInput matches what is actually drawn in all eight needsInput x cost x time combinations.
• Refactor parity. Retry, pull-to-refresh, effective search query, tray narrowing, sections, projectOptions ordering/dedupe and isLoading gating in use-agent-session-list-data.ts are semantically identical to the previous inline logic. No conditional hooks; no stale closure in the focus effect.
• FAB geometry. The list's contentContainerStyle inset (tabBarHeight + FAB_SIZE + FAB_MARGIN) matches the FAB's top edge, and tabBarOnlyClearanceStyle is applied exactly in the surfaces where the FAB is hidden.
• Prop rename. isSearchPending -> showSearchBusy has no remaining references anywhere in apps/mobile.

Assumptions

• Tests were not executed; all conclusions come from reading code at 0a0b74e2f. The PR reports apps/mobile and targeted web router suites passing.

Fix these issues in Kilo Cloud

---

_{Reviewed by claude-opus-5 · Input: 30 · Output: 4.9K · Cached: 578.6K}

_{Review guidance: REVIEW.md from base branch main}

[iscekic]

(bot) CI waiver: the only failing current-head check is test, caused by no partition of relation "model_experiment_request" found for row in unrelated model-experiment tests. This section does not change that area. The shared CI fix is tracked in #4949; per the continuation handoff, this external failure is waived for this PR gate.

[iscekic]

(bot) E2E completion: the prior blocked note is superseded. Final iOS verification and focused latest-head search re-verification both returned VERIFICATION PASSED.; the PR description contains scenarios and uploaded evidence. All section-owned stack, simulator, recorder, remote CLI, and E2E slot resources were released.