Skip to content

fix(ci): August model_experiment partitions and record.sh adb - #4949

Merged
iscekic merged 1 commit into
mainfrom
ci-partition-adb-a1b2
Aug 1, 2026
Merged

fix(ci): August model_experiment partitions and record.sh adb#4949
iscekic merged 1 commit into
mainfrom
ci-partition-adb-a1b2

Conversation

@iscekic

@iscekic iscekic commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Unblocks CI test after 2026-08-01: seed Aug–Oct model_experiment_request partitions and provision the rolling window in Jest (same pattern as Exa).
  • Cron uses the shared provision helper.
  • apps/mobile/e2e/record.sh finds adb via Homebrew android-commandlinetools (matches appium.sh / mobile-android.ts).

Test plan

  • bash -n apps/mobile/e2e/record.sh
  • pnpm exec tsx --test dev/local/appium-wrapper.test.ts (11/11)
  • provision helper smoke for Aug 2026 window
  • CI test green on this PR

- Migration + Jest provision for model_experiment_request months
- Shared provision helper used by cron and workerSetup
- record.sh resolves Homebrew android-commandlinetools adb
@kilo-code-bot

kilo-code-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

High confidence: the extracted partition-provisioning helper is behavior-identical to the previous inline cron loop, the new 0201 seed migration matches the existing 0142 partition naming/bounds so it is a safe no-op where cron already provisioned Aug–Oct 2026, and the record.sh adb resolution mirrors appium.sh.

Verification notes

  • 0201_snapshot.json is byte-identical to 0200_snapshot.json after removing id/prevId, and the journal chain (prevId linkage, idx: 201) is consistent — no schema drift.
  • CREATE TABLE IF NOT EXISTS ... PARTITION OF is idempotent for the same partition name, and the parent's indexes propagate automatically to partitions attached later, so no per-partition index DDL is required here (unlike exa_usage_log, whose partial indexes are not defined on the parent).
  • provisionModelExperimentRequestPartitions builds identifiers from format(target, 'yyyy_MM') only, so the sql.raw usage carries no injection surface; the unqualified table names preserve the pre-existing cron/migration behavior.
  • Unit tests cover both the happy window and per-partition failure isolation; workerSetup.ts treats any provisioning failure as fatal, matching the Exa pattern.
Files Reviewed (8 files)
  • apps/mobile/e2e/record.sh
  • apps/web/src/app/api/cron/model-experiment-request-partition-maintenance/route.ts
  • apps/web/src/lib/model-experiment-request-partitions.ts
  • apps/web/src/lib/model-experiment-request-partitions.test.ts
  • apps/web/src/tests/setup/workerSetup.ts
  • packages/db/src/migrations/0201_model_experiment_request_partitions_aug.sql
  • packages/db/src/migrations/meta/0201_snapshot.json (generated)
  • packages/db/src/migrations/meta/_journal.json (generated)

Reviewed by claude-opus-5 · Input: 72 · Output: 15.2K · Cached: 2.9M

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic merged commit b9ebddc into main Aug 1, 2026
49 checks passed
@iscekic
iscekic deleted the ci-partition-adb-a1b2 branch August 1, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants