Skip to content

fix(mobile): correct sign-in language picker layering - #5482

Merged
iscekic merged 2 commits into
mainfrom
fix/mobile-signin-language-picker
Aug 25, 2026
Merged

fix(mobile): correct sign-in language picker layering#5482
iscekic merged 2 commits into
mainfrom
fix/mobile-signin-language-picker

Conversation

@iscekic

@iscekic iscekic commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Keep the sign-in globe behind toast notifications.
  • Move the language sheet above Android and iOS keyboards.
  • Show the standard translated search empty state.

Verification

  • pnpm format
  • pnpm typecheck
  • pnpm lint
  • pnpm check:unused
  • pnpm test (5,899 tests)
  • pnpm check:i18n (87 catalogs)

@iscekic iscekic self-assigned this Aug 25, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • apps/mobile/src/components/agents/session-list-screen.tsx
  • apps/mobile/src/components/agents/use-agent-session-list-data.ts
  • apps/mobile/src/components/agents/session-list-screen.mounted.test.tsx
Previous Review Summary (commit 4278743)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 4278743)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • apps/mobile/src/components/kilo-chat/app-aware-keyboard-padding.tsx
  • apps/mobile/src/components/language-picker-sheet.tsx
  • apps/mobile/src/components/language-picker-sheet.mounted.test.tsx
  • apps/mobile/src/components/login-screen.tsx
  • apps/mobile/src/components/login-screen.test.ts

Reviewed by grok-4.6 · Input: 67.4K · Output: 11.9K · Cached: 523.5K

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic merged commit 3395103 into main Aug 25, 2026
19 checks passed
@iscekic
iscekic deleted the fix/mobile-signin-language-picker branch August 25, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants