Desktop/sealion multicam#1024
Merged
Merged
Conversation
subdavis
suggested changes
Dec 8, 2021
Contributor
subdavis
left a comment
subdavis
left a comment
There was a problem hiding this comment.
When I followed the instructions, my pipeline list looked like this for a normal dataset.
| `Started ${selectedPipe.value?.name} on ${props.selectedDatasetIds.length} dataset(s).`)); | ||
|
|
||
| const checkCamNumber = async () => { | ||
| if (props.subTypeList.length === props.subTypeList.filter((item) => item === null).length) { |
Contributor
There was a problem hiding this comment.
This logic needs documentation. What is this doing? What is the whole function doing?
| sortedPipelines[name] = category; | ||
| } else if (props.subTypeList.length === props.subTypeList.filter((item) => item === 'multicam').length | ||
| && (multiCamPipelineMarkers.includes(name))) { | ||
| if (name.split('-')[0] === camNumber.value.toString()) { |
Contributor
There was a problem hiding this comment.
this gives me anxiety. I don't know what to do about it though.
Collaborator
Author
There was a problem hiding this comment.
could restructure const multiCamPipelineMarkers = ['2-cam', '3-cam']; to be an object with a key-name and the number of cameras it represents?
subdavis
approved these changes
Dec 9, 2021
subdavis
added a commit
that referenced
this pull request
Dec 20, 2021
* Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
subdavis
added a commit
that referenced
this pull request
Dec 20, 2021
* Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
subdavis
added a commit
that referenced
this pull request
Dec 20, 2021
* Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
subdavis
added a commit
that referenced
this pull request
Dec 28, 2021
* Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
subdavis
added a commit
that referenced
this pull request
Jan 3, 2022
* Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
subdavis
added a commit
that referenced
this pull request
Jan 20, 2022
* Mongo 1: Server side implementation (#1066) * Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com> * Mongo 2: Rollback API (#1067) * Implement rollback * Switch to POST /dive_annotation/rollback * Mongo 3: Utilize new endpoints in celery (#1068) * Utilize new endpoints in celery * Respond to comments * Linting, formatting, and unit tests * respond to comments * Import shutil * Client changes to support revisions (#1070) * Remove broken summary and report generation (#1071) * Add simple sharing test and new indices * Migraction script updates * Add loading state to clone button * label fetch Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1019
Got it to run in it's basic form by allowing the pipeline type using some very rough regEx. Would like a better way to do this in the future.
Background:
Updates:
writeMultiCamStereoPipelineArgsto include the trackwriter used by the new pipesmultiCamPipelineMarkersfor 2-cam and 3-cam pipes.allowedPatternsto support the 2/3-cam pipesRunPipelineMenuwill no on load determine the number of cameras in the metadata. It will also do this when theprops.subTypeListchanges (this happens directly after importing). It will then only display the pipelines relevant to the data type'stereo' | 'multicam'as well as the number of cameras2 | 3