Mongo 3: Utilize new endpoints in celery#1068
Merged
Merged
Conversation
This was referenced Nov 22, 2021
waxlamp
modified the milestones:
Annotations in MongoDB,
Sprint November 30 - December 14
waxlamp
modified the milestones:
Sprint November 30 - December 14,
Sprint December 14 - December 28
subdavis
force-pushed
the
mongo/rollback
branch
from
9187af1 to
5be429d
Compare
subdavis
force-pushed
the
mongo/celery-updates
branch
from
2b11148 to
09dbadb
Compare
subdavis
force-pushed
the
mongo/rollback
branch
2 times, most recently
from
15529b3 to
9b8862a
Compare
subdavis
force-pushed
the
mongo/celery-updates
branch
from
09dbadb to
ca38811
Compare
BryonLewis
requested changes
Dec 22, 2021
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
I still need to do a more thorough review, but wanted to log these things right now.
subdavis
force-pushed
the
mongo/celery-updates
branch
from
ca38811 to
33d80d7
Compare
subdavis
force-pushed
the
develop-mongo-tracks
branch
from
06cd9de to
9e390c9
Compare
subdavis
force-pushed
the
mongo/celery-updates
branch
from
33d80d7 to
507f990
Compare
Contributor
Author
|
Combined this and test/formatting updates into one PR because the rebase was tedious. |
BryonLewis
requested changes
Jan 3, 2022
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
besides the one test it looks like integration tests now fully work. I also did some training and applying the trained data to another dataset and that seems to now work properly as well.
| assert len(new_tracks.keys()) == 1, "Should have a single track" | ||
| client.delete(f'item/{newfile["itemId"]}') # Remove the uploaded detections | ||
| assert len(new_tracks_list) == 1, "Should have a single track" | ||
| client.delete(f'dive_annotation?folderId={dataset["_id"]}&revision={old_revision}') |
Collaborator
There was a problem hiding this comment.
The rollback endpoint needs an empty argument to prevent the route dividing /r/o/l/l/b/a/c/k:
https://github.com/Kitware/dive/blob/develop-mongo-tracks/server/dive_server/views_annotation.py#L33
self.route("POST", ("rollback",), self.rollback)
I think the client.delete should be swapped to: client.post(f'dive_annotation/rollback?folderId={dataset["_id"]}&revision={old_revision}')
BryonLewis
approved these changes
Jan 3, 2022
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
looks good, pulled/built and did some more local testing and ran integration tests successfully.
subdavis
added a commit
that referenced
this pull request
Jan 3, 2022
* Utilize new endpoints in celery * Respond to comments * Linting, formatting, and unit tests * respond to comments
subdavis
added a commit
that referenced
this pull request
Jan 20, 2022
* Mongo 1: Server side implementation (#1066) * Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com> * Mongo 2: Rollback API (#1067) * Implement rollback * Switch to POST /dive_annotation/rollback * Mongo 3: Utilize new endpoints in celery (#1068) * Utilize new endpoints in celery * Respond to comments * Linting, formatting, and unit tests * respond to comments * Import shutil * Client changes to support revisions (#1070) * Remove broken summary and report generation (#1071) * Add simple sharing test and new indices * Migraction script updates * Add loading state to clone button * label fetch Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewer notes
I think this one is pretty straightforward.
urllib.urlretrieve