Mongo 5: Remove broken summary and report generation#1071
Merged
subdavis merged 1 commit intoJan 5, 2022
Conversation
waxlamp
modified the milestones:
Annotations in MongoDB,
Sprint November 30 - December 14
waxlamp
modified the milestones:
Sprint November 30 - December 14,
Sprint December 14 - December 28
Member
I'll need quite a bit of background on what this was supposed to be, what kinds of problems it was meant to solve, etc. Let's discuss it the next time we have a planning meeting. |
subdavis
changed the title
subdavis
force-pushed
the
mongo/client-changes
branch
from
59f3f4d to
95b01b8
Compare
subdavis
force-pushed
the
mongo/remove-summary-report-generation
branch
from
51bb9d9 to
75a5628
Compare
subdavis
changed the base branch from
mongo/client-changes
to
mongo/celery-updates
subdavis
force-pushed
the
develop-mongo-tracks
branch
from
4baea43 to
1082ca6
Compare
subdavis
force-pushed
the
mongo/remove-summary-report-generation
branch
from
75a5628 to
bade990
Compare
waxlamp
modified the milestones:
Sprint December 14 - December 28,
Sprint December 28 - January 11
BryonLewis
approved these changes
Jan 5, 2022
Collaborator
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Pulled, tested and ran integration tests. Looks like all instances of the summary stuff were removed properly. Assuming that we may add something back in once the switch to mongo is done, probably using your aggregation pipline stuff you were working on the other day.
subdavis
added a commit
that referenced
this pull request
Jan 20, 2022
* Mongo 1: Server side implementation (#1066) * Poetry fix (#1087) * Poetry fix * Add check for app root * Desktop/sealion multicam (#1024) * init * Allowing multicam to write tracks * inut name change * lint fixes * Updates to multicam * fixing import loading * removing multicamImageFiles change * Fixing various issues * mend * mend * switching to every * Example without fetching metadata (#1088) Co-authored-by: Brandon Davis <brandon.davis@kitware.com> * Server-side implementation * Include description and timestamp * Respond to comments * Switch to checking mongo results * select sub-element * Unmangle indices Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com> * Mongo 2: Rollback API (#1067) * Implement rollback * Switch to POST /dive_annotation/rollback * Mongo 3: Utilize new endpoints in celery (#1068) * Utilize new endpoints in celery * Respond to comments * Linting, formatting, and unit tests * respond to comments * Import shutil * Client changes to support revisions (#1070) * Remove broken summary and report generation (#1071) * Add simple sharing test and new indices * Migraction script updates * Add loading state to clone button * label fetch Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops a whole heap of untested and unused code. I found out in #1065 that users have never been able to see the summary page, and nobody ever mentioned it, so this drops the page, the report generation, and the Max-N csv generation that was also broken for a long time, untested, and seemed to be of dubious value.
We should have a follow-up discussion