Fix mobile hacker dashboard actions and add reminders - #483
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR adds an accepted-reminder email action for accepted hackers and updates the admin hacker table to remain horizontally usable on small screens. ChangesMobile hacker table
Acceptance reminder email
Estimated code review effort: 3 (Moderate) | ~25 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 7 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (7 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/blade/src/app/_components/admin/hackathon/hackers/hackers-table.tsx`:
- Around line 452-457: The swipe hint in hackers-table.tsx is currently visual
only, so the horizontally scrollable region needs a programmatic accessibility
cue. Update the scroll container around the Table to expose that more content is
available off-screen, using appropriate ARIA/semantic HTML on the container
and/or its associated hint so mobile assistive tech can announce the
relationship. Keep the change localized to the hackers-table component and
ensure the cue is tied to the existing swipe hint text and the overflow-x-auto
region.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: 801f345c-9c71-45c1-b9f4-855f3a40dc6e
📒 Files selected for processing (1)
apps/blade/src/app/_components/admin/hackathon/hackers/hackers-table.tsx
| <p className="text-center text-xs text-muted-foreground md:hidden"> | ||
| Swipe left or right on the table to review Discord, email, status, and | ||
| admit/waitlist actions. | ||
| </p> | ||
| <div className="w-full overflow-x-auto overscroll-x-contain rounded-md border [-webkit-overflow-scrolling:touch] md:border-0"> | ||
| <Table className="min-w-[1120px]"> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Associate the swipe hint with the scroll region.
The new hint is visual-only right now. On mobile assistive tech, the horizontally scrollable container has no programmatic cue that more columns/actions are off-screen.
Suggested fix
- <p className="text-center text-xs text-muted-foreground md:hidden">
+ <p
+ id="hackers-table-mobile-hint"
+ className="text-center text-xs text-muted-foreground md:hidden"
+ >
Swipe left or right on the table to review Discord, email, status, and
admit/waitlist actions.
</p>
- <div className="w-full overflow-x-auto overscroll-x-contain rounded-md border [-webkit-overflow-scrolling:touch] md:border-0">
+ <div
+ aria-describedby="hackers-table-mobile-hint"
+ aria-label="Hackers table. Horizontally scroll on small screens to access additional columns."
+ tabIndex={0}
+ className="w-full overflow-x-auto overscroll-x-contain rounded-md border [-webkit-overflow-scrolling:touch] md:border-0"
+ >As per path instructions, apps/blade/** requires checking accessibility, including “ARIA” and “semantic HTML”.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <p className="text-center text-xs text-muted-foreground md:hidden"> | |
| Swipe left or right on the table to review Discord, email, status, and | |
| admit/waitlist actions. | |
| </p> | |
| <div className="w-full overflow-x-auto overscroll-x-contain rounded-md border [-webkit-overflow-scrolling:touch] md:border-0"> | |
| <Table className="min-w-[1120px]"> | |
| <p | |
| id="hackers-table-mobile-hint" | |
| className="text-center text-xs text-muted-foreground md:hidden" | |
| > | |
| Swipe left or right on the table to review Discord, email, status, and | |
| admit/waitlist actions. | |
| </p> | |
| <div | |
| aria-describedby="hackers-table-mobile-hint" | |
| aria-label="Hackers table. Horizontally scroll on small screens to access additional columns." | |
| tabIndex={0} | |
| className="w-full overflow-x-auto overscroll-x-contain rounded-md border [-webkit-overflow-scrolling:touch] md:border-0" | |
| > | |
| <Table className="min-w-[1120px]"> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/blade/src/app/_components/admin/hackathon/hackers/hackers-table.tsx`
around lines 452 - 457, The swipe hint in hackers-table.tsx is currently visual
only, so the horizontally scrollable region needs a programmatic accessibility
cue. Update the scroll container around the Table to expose that more content is
available off-screen, using appropriate ARIA/semantic HTML on the container
and/or its associated hint so mobile assistive tech can announce the
relationship. Keep the change localized to the hackers-table component and
ensure the cue is tied to the existing swipe hint text and the overflow-x-auto
region.
Source: Path instructions
DVidal1205
changed the title
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/blade/src/app/_components/admin/hackathon/hackers/acceptance-reminder-button.tsx (1)
93-97: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueLoading spinner replaces button entirely — minor a11y/UX nit.
When
isLoadingis true, theSend Reminderbutton is unmounted and replaced by a bareLoader2spinner with norole="status"/aria-liveregion, so screen reader users get no feedback that a send is in progress.♻️ Suggested tweak
- {isLoading ? ( - <Loader2 className="animate-spin" /> - ) : ( - <Button onClick={handleSendReminder}>Send Reminder</Button> - )} + <Button onClick={handleSendReminder} disabled={isLoading}> + {isLoading ? ( + <Loader2 className="h-4 w-4 animate-spin" aria-hidden="true" /> + ) : ( + "Send Reminder" + )} + </Button>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@apps/blade/src/app/_components/admin/hackathon/hackers/acceptance-reminder-button.tsx` around lines 93 - 97, The loading state in acceptance-reminder-button.tsx currently unmounts the Send Reminder control and shows only a bare Loader2 spinner, which removes both button context and accessible progress feedback. Update the isLoading branch in AcceptanceReminderButton so the Button remains present/disabled while sending, and add an accessible status indicator (for example, a role="status" or aria-live message) tied to the existing Loader2 spinner and handleSendReminder flow.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/email/src/hackathons/templates.ts`:
- Around line 40-41: The AcceptedReminder mapping is still pointing at the same
template ID as Accepted, so the reminder email reuses the acceptance copy.
Update the reminder template constants in templates.ts for the hackathon presets
so AcceptedReminder references the dedicated reminder template ID instead of the
Accepted one, using the AcceptedReminder symbol and the preset template map as
the place to change. If the dedicated IDs are not available yet, keep the TODO
but ensure the reminder path is wired separately so it can be swapped in
cleanly.
---
Nitpick comments:
In
`@apps/blade/src/app/_components/admin/hackathon/hackers/acceptance-reminder-button.tsx`:
- Around line 93-97: The loading state in acceptance-reminder-button.tsx
currently unmounts the Send Reminder control and shows only a bare Loader2
spinner, which removes both button context and accessible progress feedback.
Update the isLoading branch in AcceptanceReminderButton so the Button remains
present/disabled while sending, and add an accessible status indicator (for
example, a role="status" or aria-live message) tied to the existing Loader2
spinner and handleSendReminder flow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: CHILL
Plan: Pro
Run ID: a911005d-1606-48f0-a741-66d583cb752f
📒 Files selected for processing (5)
apps/blade/src/app/_components/admin/hackathon/hackers/acceptance-reminder-button.tsxapps/blade/src/app/_components/admin/hackathon/hackers/hacker-status-toggle.tsxapps/blade/src/app/_components/admin/hackathon/hackers/hackers-table.tsxpackages/email/src/hackathons/index.tspackages/email/src/hackathons/templates.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/blade/src/app/_components/admin/hackathon/hackers/hackers-table.tsx
2 participants
Summary
md:*classesAcceptedReminderhackathon email kind with its own subjectAcceptedReminderto the same Listmonk template IDs asAccepteduntil the real reminder template IDs are providedVerification
pnpm install --frozen-lockfilepnpm exec prettier --check apps/blade/src/app/_components/admin/hackathon/hackers/hackers-table.tsx apps/blade/src/app/_components/admin/hackathon/hackers/hacker-status-toggle.tsx apps/blade/src/app/_components/admin/hackathon/hackers/acceptance-reminder-button.tsx packages/email/src/hackathons/templates.ts packages/email/src/hackathons/index.tspnpm --dir apps/blade exec eslint src/app/_components/admin/hackathon/hackers/hackers-table.tsx src/app/_components/admin/hackathon/hackers/hacker-status-toggle.tsx src/app/_components/admin/hackathon/hackers/acceptance-reminder-button.tsxpnpm --filter=@forge/email lintpnpm --filter=@forge/api lintpnpm --filter=@forge/blade lintpnpm --filter=@forge/email typecheckpnpm --filter=@forge/api typecheckpnpm --filter=@forge/blade typecheckNotes
pnpm --filter=@forge/blade buildis still blocked locally by missing required env vars (STRIPE_SECRET_KEY, MinIO keys, Apple Wallet pass vars,AUTH_SECRET,BLADE_URL, Google service account vars).Summary by CodeRabbit