Skip to content

bug - #490

Merged
DanielJEfres merged 5 commits into
mainfrom
bktkreminders
Jul 11, 2026
Merged

bug#490
DanielJEfres merged 5 commits into
mainfrom
bktkreminders

Conversation

@morallyearlgrey

@morallyearlgrey morallyearlgrey commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

tk was announccing about lanyards and the banner was incorrect
Screenshot 2026-07-11 at 12 24 18 PM

Summary by CodeRabbit

  • Bug Fixes
    • Updated the Hack reminders banner image URL.
    • Adjusted the final Hack reminder message to remove the “lanyard” reference while keeping the Blade QR code wording.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@DanielJEfres, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 7e0baccb-81b6-45f1-b793-7d0d8eb379b8

📥 Commits

Reviewing files that changed from the base of the PR and between 265e068 and 8c195c2.

📒 Files selected for processing (1)
  • apps/cron/src/crons/reminder.ts
📝 Walkthrough

Walkthrough

Updated the Hack reminders banner image URL and removed the “lanyard” reference from the final Discord reminder message.

Changes

Hack reminder content

Layer / File(s) Summary
Reminder content updates
apps/cron/src/crons/reminder.ts
The banner image URL now points to the new Imgur link, and the final reminder mentions only the Blade QR code.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • KnightHacks/forge#489: Updates other Hack reminder constants and embed content in the same reminder implementation.

Suggested labels: CRON, Bug, Minor

🚥 Pre-merge checks | ✅ 7 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague and does not include the required issue-number prefix or a meaningful description. Rename it to something like "[#123] Fix hack reminder banner text and image URL".
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No Hardcoded Secrets ✅ Passed Changed file only updates a banner URL and message text; no hardcoded API keys, tokens, passwords, or secret-like literals were found.
Validated Env Access ✅ Passed apps/cron/src/crons/reminder.ts uses validated env imports only; no direct process.env appears in the PR diff.
No Typescript Escape Hatches ✅ Passed apps/cron/src/crons/reminder.ts has no any, ts-ignore/expect-error, or non-null assertions in the changed logic.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bktkreminders

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/cron/src/crons/reminder.ts`:
- Line 26: Update HACK_BANNER_IMAGE to use the direct image asset URL rather
than the Imgur album page, using the appropriate https://i.imgur.com/... image
link so Discord can render the banner reliably.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: c2b47740-fe9f-41f2-a556-b5014c4a7ee3

📥 Commits

Reviewing files that changed from the base of the PR and between b0bf4aa and 1d70d88.

📒 Files selected for processing (1)
  • apps/cron/src/crons/reminder.ts

Comment thread apps/cron/src/crons/reminder.ts Outdated
@DanielJEfres

Copy link
Copy Markdown
Contributor

my bad i meant to explain lol

@DanielJEfres
DanielJEfres added this pull request to the merge queue Jul 11, 2026
Merged via the queue into main with commit b6b040b Jul 11, 2026
10 checks passed
@DanielJEfres
DanielJEfres deleted the bktkreminders branch July 11, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants