Replace Ext.isArray with Array.isArray#7865
Merged
Merged
Conversation
Contributor
Author
|
@ankurjuneja I can't recall which PR, but I saw some reference recently to these two Ext.isArray lines in plot.js being the last Ext usages (some dependency update PR maybe?). Anyway, this PR removes / replaces that so this file doesn't have that Ext dependency anymore. |
labkey-nicka
approved these changes
Jul 20, 2026
ankurjuneja
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Replace the final usages of Ext in the vis/plot.js file with a simple isArray replacement.
Related Pull Requests
Changes