Move TargetedMS QC/chart UI off ExtJS to plain JS + HTML#1257
Open
ankurjuneja wants to merge 5 commits into
Open
Move TargetedMS QC/chart UI off ExtJS to plain JS + HTML#1257ankurjuneja wants to merge 5 commits into
ankurjuneja wants to merge 5 commits into
Conversation
cnathe
reviewed
Jul 21, 2026
| public void addClientDependencies(ClientDependencies dependencies) | ||
| { | ||
| dependencies.add("Ext4"); | ||
| dependencies.add("Ext4"); // LABKEY.vis (vis/vis) still uses Ext.isArray for log-scale axes |
Contributor
There was a problem hiding this comment.
@ankurjuneja this is the PR I was thinking of when I tagged you for the changes here LabKey/platform#7865. Not sure if that changes this dependency at all, but wanted to call it out.
Contributor
Author
There was a problem hiding this comment.
Thanks @cnathe, I will verify (and remove) if we need the Ext4 dependency for calibration curve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We are gradually removing our dependency on ExtJS. ExtJS is old, heavy, and something we want to stop using. Each of these screens used ExtJS only as a wrapper around plain data or existing non-ExtJS chart code, so we can swap in simple HTML, plain JavaScript, and jQuery without changing what the user sees. This makes the code lighter, easier to read, and easier to maintain.
Related Pull Requests
Changes