Skip to content

Add Sass (scss) support - #72

Merged
LeaVerou merged 2 commits into
PrismJS:gh-pagesfrom
MoOx:scss
Mar 12, 2013
Merged

Add Sass (scss) support#72
LeaVerou merged 2 commits into
PrismJS:gh-pagesfrom
MoOx:scss

Conversation

@MoOx

@MoOx MoOx commented Feb 2, 2013

Copy link
Copy Markdown
Contributor

#49 merged with latest changes :)

@LeaVerou

LeaVerou commented Feb 2, 2013

Copy link
Copy Markdown
Member

Thanks again!

A couple things:

  • You don't need to modify prism.js, that's the version of Prism the Prism website uses and there aren't any SASS examples there.
  • You don't need to modify examples.html, that's mostly meant to test the Prism core. Loading all the languages there would bloat the website. I'm thinking of having separate pages per language, just like plugins.
  • Is there any online version where I could play with it and see how it works? SASS highlighting is pretty tricky. If not, it's ok, I'll just test it manually, but thought I'd ask first. :)

@MoOx

MoOx commented Feb 2, 2013

Copy link
Copy Markdown
Contributor Author
  • Do you want me to undo the modification on prism.js for the PR ?
  • Nice idea for an alternate more-examples.html :). Again do you want me to undo this ? Or maybe you will keep it to create the new example page ?
  • You can it see it running online on the homepage here http://compass-recipes.moox.fr/

(Btw, it's Sass not SASS :) )

@LeaVerou

LeaVerou commented Feb 3, 2013

Copy link
Copy Markdown
Member
  1. Yes please :)
  2. Probably a better idea would be to have a separate page for languages, just like we do for plugins. Or extend test.html to allow testing for all languages. Or both. But for now, it should be removed from examples.html
  3. Looks good!

@MoOx

MoOx commented Feb 4, 2013

Copy link
Copy Markdown
Contributor Author

I undo the changes you ask.
Just ping me if you create more example page to add the Sass example back.

@jwebcat

jwebcat commented Mar 12, 2013

Copy link
Copy Markdown

Hey Ya'll.

What is the status on this? I would love to see this merged.

LeaVerou added a commit that referenced this pull request Mar 12, 2013
Add Sass (scss) support
@LeaVerou
LeaVerou merged commit 4309608 into PrismJS:gh-pages Mar 12, 2013
@LeaVerou

Copy link
Copy Markdown
Member

Merged, thanks! Lets see how it goes.

@MoOx

MoOx commented Mar 12, 2013

Copy link
Copy Markdown
Contributor Author

I'm watching the repo, to handle support for this one :)

@jwebcat

jwebcat commented Mar 12, 2013

Copy link
Copy Markdown

I'm so happy :) thanks for coding this bit Maxime! And thanks for merging
this! I will post here once I mod my custom color scheme monokai dark style.
On Mar 12, 2013 1:38 PM, "Maxime Thirouin" notifications@github.com wrote:

I'm watching the repo, to handle support for this one :)


Reply to this email directly or view it on GitHubhttps://github.com//pull/72#issuecomment-14801650
.

@MoOx

MoOx commented Mar 12, 2013

Copy link
Copy Markdown
Contributor Author

@jwebcat did you take a look to mine https://github.com/MoOx/sass-prism-theme-base ?

@jwebcat

jwebcat commented Mar 12, 2013

Copy link
Copy Markdown

I did, I forked it.
I was super excited to use it, but when I compile your stylesheet using
compass and use it with prism my scss syntax highlighting doesn't look like
in your screenshot. Sadface :(
I am using prism with the Jekyll plugin.
Did I miss a step?
In Your link to compass recipes the syntax highlighting isn't like the
screenshot either.
Any ideas?
On Mar 12, 2013 2:11 PM, "Maxime Thirouin" notifications@github.com wrote:

@jwebcat https://github.com/jwebcat did you take a look to mine
https://github.com/MoOx/prism-sass-theme-monokai ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/72#issuecomment-14803650
.

@MoOx

MoOx commented Mar 13, 2013

Copy link
Copy Markdown
Contributor Author

I'm working on that. Please follow this issue MoOx/sass-prism-theme-base#1 (btw, I rename the repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants