Skip to content

Add Sass/Scss support - #49

Closed
MoOx wants to merge 7 commits into
PrismJS:gh-pagesfrom
MoOx:sass
Closed

Add Sass/Scss support#49
MoOx wants to merge 7 commits into
PrismJS:gh-pagesfrom
MoOx:sass

Conversation

@MoOx

@MoOx MoOx commented Oct 29, 2012

Copy link
Copy Markdown
Contributor

The sass/scss syntax embed a lot of things. It works great with a theme I made based on Monokai https://github.com/MoOx/sass-prism-theme-base
Maybe I should make a PR with the CSS generated by this theme.

@MoOx

MoOx commented Nov 15, 2012

Copy link
Copy Markdown
Contributor Author

I'll update this PR with a lighter version as you recommend

@MoOx

MoOx commented Nov 15, 2012

Copy link
Copy Markdown
Contributor Author

I've try something, but it fails since the order of the declaration are important. Using extend() we can't control order of the parsing, so some rules are not parsed & this doesn't take effect. That's why I overwrite a lot of thing.
Beside that problem, I understand that I've put too much thing, non especially sass/scss related, but this is another issue :)

@LeaVerou

Copy link
Copy Markdown
Member

You can use insertBefore for that, look here for an example: http://prismjs.com/components/prism-javascript.js

Regarding not including too many tokens for CSS, that was a conscious choice, since most use cases don't need that kind of granularity.

@MoOx

MoOx commented Nov 15, 2012

Copy link
Copy Markdown
Contributor Author

Oh sorry, I don't look closer enough. This is just what I need. Your highlighter is so well done.

@MoOx

MoOx commented Dec 8, 2012

Copy link
Copy Markdown
Contributor Author

Completely rewrote. Lighter & inherit from CSS. Tell me what you think about that now.

MoOx added 2 commits December 10, 2012 07:58
I don't really know what I did. Too obsessed by the selector regex maybe…
@MoOx

MoOx commented Feb 1, 2013

Copy link
Copy Markdown
Contributor Author

What about this PR ? :)

@LeaVerou

LeaVerou commented Feb 2, 2013

Copy link
Copy Markdown
Member

Gah, the pull request cannot be merged. Could you please submit a new one? Sorry I took so long, it's my fault :(

@LeaVerou LeaVerou closed this Feb 2, 2013
@MoOx MoOx mentioned this pull request Feb 2, 2013
@MoOx MoOx mentioned this pull request May 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants