Skip to content

Extend review-agent phrasing rule to all finding severities#53

Merged
sebastientaggart merged 1 commit into
devfrom
feature/critical-phrasing-rule
Apr 8, 2026
Merged

Extend review-agent phrasing rule to all finding severities#53
sebastientaggart merged 1 commit into
devfrom
feature/critical-phrasing-rule

Conversation

@sebastientaggart

Copy link
Copy Markdown
Member

Extends the review-agent phrasing rule so CRITICAL findings — not just WARNING and NOTE — must be written as self-contained, standalone-title sentences. This ensures advisory-mode follow-up issues promoted from CRITICAL findings inherit the same usable-title guarantee.

Issue #51

@sebastientaggart

Copy link
Copy Markdown
Member Author

Review Summary

Verdict: APPROVE

Findings

No issues found. Code looks correct and follows project conventions. The phrasing rule is consistently extended to CRITICAL findings in both the source skill (skills/review-agent.md) and the generated .claude/review-agent-prompt.md, and the regenerated hash matches between the two files.

@sebastientaggart
sebastientaggart merged commit 3bc301f into dev Apr 8, 2026
2 checks passed
This was referenced Apr 8, 2026
@sebastientaggart
sebastientaggart deleted the feature/critical-phrasing-rule branch April 8, 2026 15:32
sebastientaggart added a commit that referenced this pull request Apr 8, 2026
…rule

Extend review-agent phrasing rule to all finding severities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant