Pncconf: Add P value message when servo period is changed#4263
Open
Sigma1912 wants to merge 1 commit into
Open
Pncconf: Add P value message when servo period is changed#4263Sigma1912 wants to merge 1 commit into
Sigma1912 wants to merge 1 commit into
Conversation
The P value in the motor PID settings is recommended to be set according to the servo period value. If a config is changed using pncconf tool and the servo period is changed the P values should usually be adjusted as well. This PR adds a popup so the user can choose to have the P values adjusted accordingly.
Sigma1912
force-pushed
the
pncconf_Add-p-value-check
branch
from
July 23, 2026 16:22
847dfe1 to
f1299da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The P value in the motor PID settings is recommended to be set according to the servo period value. If a config is changed using pncconf tool and the servo period is changed the P values should usually be adjusted as well. This PR adds a popup so the user can choose to have the P values adjusted accordingly.
Adresses https://forum.linuxcnc.org/39-pncconf/59018-if-servo-period-is-changed-the-coresponding-p-values-for-pid-do-not-change#348002
cc: @c-morley