Proposed fix for "FIXTHIS too verbose"#442
Merged
SebKuzminsky merged 1 commit intoLinuxCNC:masterfrom Jun 15, 2018
Merged
Conversation
I don't like the idea of having two different styles for the G-code and M-code tables, but there are just too many G-codes available to not have it be verbose. So I ask the user to pick the blank cells for G-codes. I could "reverse" the M-codes table too, if consistency between them is thought to be important. The tables are broken up to avoid trying to print one table 100 lines long. Signed-off-by: Kim Kirwan <Kim@KimKirwan.com>
Collaborator
|
That looks great, thanks! |
Collaborator
|
71, 71.1, 72, 72.1 will be allocated at some point, but at the moment there is an existing remap for those who choose to install it, so those need to still be remappable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't like the idea of having two different styles
for the G-code and M-code tables, but there are just
too many G-codes available to not have it be verbose.
So I ask the user to pick the blank cells for G-codes.
I could "reverse" the M-codes table too, if consistency
between them is thought to be important.
The tables are broken up to avoid trying to print
one table 100 lines long.
Signed-off-by: Kim Kirwan Kim@KimKirwan.com