rs274ngc: Don't use RTAPI. This is non-RT userspace code - #4493
Merged
Conversation
BsAtHome
pushed a commit
that referenced
this pull request
Sep 2, 2026
interp_arc.cc, interp_execute.cc and interp_find.cc included <rtapi_math.h> but use no rtapi_ symbols. Their math functions and M_PIl come from <math.h>, which they already include after defining _GNU_SOURCE. The interpreter is built only as the userspace librs274.so, so the kernel branch of rtapi_math.h never applied. Completes the include cleanup that #4493 did for interp_convert.cc and interp_read.cc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the RTAPI string calls in the g-code interpreter. There is no RT in the interpreter and it is an unnecessary complication and rather slow in some of the paths where it is being used.
Unlike #4492, this does not change RTAPI code, which is a chore for another time.