Skip to content

ci(windows): use boost from source#3231

Merged
ReenigneArcher merged 1 commit intomasterfrom
ci/windows/use-boost-from-source
Sep 28, 2024
Merged

ci(windows): use boost from source#3231
ReenigneArcher merged 1 commit intomasterfrom
ci/windows/use-boost-from-source

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

Description

Use boost from source.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.84%. Comparing base (68eb8d2) to head (0947605).
Report is 100 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3231      +/-   ##
=========================================
+ Coverage    9.71%   9.84%   +0.13%     
=========================================
  Files          77     101      +24     
  Lines       14058   17974    +3916     
  Branches     6455    8402    +1947     
=========================================
+ Hits         1366    1770     +404     
- Misses      12029   13324    +1295     
- Partials      663    2880    +2217     
Flag Coverage Δ
Linux 7.27% <ø> (?)
Windows 5.07% <ø> (ø)
macOS-12 10.78% <ø> (-0.02%) ⬇️
macOS-13 10.71% <ø> (+0.02%) ⬆️
macOS-14 10.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 59 files with indirect coverage changes

@ReenigneArcher ReenigneArcher force-pushed the ci/windows/use-boost-from-source branch from 64cf692 to 0947605 Compare September 27, 2024 23:56
@sonarqubecloud
Copy link
Copy Markdown

@ReenigneArcher
Copy link
Copy Markdown
Member Author

ReenigneArcher commented Sep 28, 2024

@cgutman msys2 updated boost to 1.86, causing build failures. I'm not sure if there's a better fix or we should just roll back to 1.85 in this PR for now.

e.g. https://github.com/LizardByte/Sunshine/actions/runs/11060050129/job/30729758238

Edit: I will merge to get a working build again. Let me know if you think we should do something else to fix this in the long run.

@ReenigneArcher ReenigneArcher added this to the stable release milestone Sep 28, 2024
@ReenigneArcher ReenigneArcher merged commit e10b24a into master Sep 28, 2024
@ReenigneArcher ReenigneArcher deleted the ci/windows/use-boost-from-source branch September 28, 2024 02:39
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost 1.86 causes build failures

1 participant