Skip to content

test(coverage): ignore _deps directory#3233

Merged
ReenigneArcher merged 1 commit intomasterfrom
tests/coverage/ignore-_deps-directory
Sep 28, 2024
Merged

test(coverage): ignore _deps directory#3233
ReenigneArcher merged 1 commit intomasterfrom
tests/coverage/ignore-_deps-directory

Conversation

@ReenigneArcher
Copy link
Copy Markdown
Member

Description

Discovered in #3231, the coverage generation may fail when building boost from source.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@ReenigneArcher ReenigneArcher changed the title tests(coverage): ignore _deps directory test(coverage): ignore _deps directory Sep 28, 2024
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 28, 2024 03:52
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.84%. Comparing base (e03c598) to head (c49727b).
Report is 99 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3233      +/-   ##
=========================================
+ Coverage    9.71%   9.84%   +0.13%     
=========================================
  Files          77     101      +24     
  Lines       14058   17974    +3916     
  Branches     6455    8402    +1947     
=========================================
+ Hits         1366    1770     +404     
- Misses      10072   13331    +3259     
- Partials     2620    2873     +253     
Flag Coverage Δ
Linux 7.27% <ø> (?)
Windows 5.07% <ø> (ø)
macOS-12 10.79% <ø> (-0.02%) ⬇️
macOS-13 10.70% <ø> (+0.01%) ⬆️
macOS-14 10.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 58 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 1071f13 into master Sep 28, 2024
@ReenigneArcher ReenigneArcher deleted the tests/coverage/ignore-_deps-directory branch September 28, 2024 04:56
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Oct 9, 2024
c2vi pushed a commit to c2vi/Sunshine that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is AppImage support dropped?

1 participant