refactor(sonar): migrate worker threads to std::jthread#5398
Merged
Conversation
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #5398 +/- ##
==========================================
- Coverage 27.15% 26.71% -0.45%
==========================================
Files 111 111
Lines 25447 25324 -123
Branches 11232 11195 -37
==========================================
- Hits 6910 6765 -145
+ Misses 17581 15516 -2065
- Partials 956 3043 +2087
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 47 files with indirect coverage changes Continue to review full report in Codecov by Harness.
|
Replaced std::thread with std::jthread across runtime services, platform publish/audio paths, streaming/video pipelines, and related unit tests. This modernizes thread lifetime management by using auto-joining threads, reducing manual join/detach risks and simplifying shutdown behavior.
ReenigneArcher
force-pushed
the
refactor/use-jthread
branch
from
a8d36ba to
d5677c1
Compare
Remove compiler version check for the experimental library flag on Apple and FreeBSD, ensuring it's consistently applied. Add missing SUNSHINE_LINK_OPTIONS to both the main sunshine target and test target for consistent linker configuration.
ReenigneArcher
force-pushed
the
refactor/use-jthread
branch
from
69c56a9 to
4c297e2
Compare
Updates CI and packaging to match newer compiler/runtime requirements across platforms: FreeBSD now installs full llvm last so compiler-rt is present, macOS 14 explicitly selects Xcode 16.2 (and Homebrew Sonoma builds require it), and Linux linking/packaging is adjusted for GCC 15 by conditionally avoiding static libstdc++ while adding gcc-libs as a runtime dependency on Arch.
ReenigneArcher
force-pushed
the
refactor/use-jthread
branch
from
2f0b6e8 to
6cb950a
Compare
Update the FreeBSD CI workflow and build docs to use LLVM 19 instead of LLVM 21, including the local compiler environment variables for FreeBSD builds.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced std::thread with std::jthread across runtime services, platform publish/audio paths, streaming/video pipelines, and related unit tests. This modernizes thread lifetime management by using auto-joining threads, reducing manual join/detach risks and simplifying shutdown behavior.
Screenshot
Issues Fixed or Closed
Fixes sonar cpp:S6168
Roadmap Issues
Type of Change
Checklist
AI Usage
See our AI usage policy.