Skip to content

fix(amf): wire h264_amf coder and profile mapping#5442

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/amf/enable-H.264-profile-and-coder-selection-alternate
Jul 24, 2026
Merged

fix(amf): wire h264_amf coder and profile mapping#5442
ReenigneArcher merged 1 commit into
masterfrom
fix/amf/enable-H.264-profile-and-coder-selection-alternate

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Alternate solution for #4927

Also resolves some sonar issues.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@ReenigneArcher
ReenigneArcher force-pushed the fix/amf/enable-H.264-profile-and-coder-selection-alternate branch 2 times, most recently from de31348 to 82767cb Compare July 23, 2026 22:48
@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.89%. Comparing base (c6bef33) to head (048b9f2).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/video.cpp 48.38% 5 Missing and 11 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5442      +/-   ##
==========================================
+ Coverage   26.70%   26.89%   +0.18%     
==========================================
  Files         111      111              
  Lines       25406    25414       +8     
  Branches    11232    11236       +4     
==========================================
+ Hits         6785     6835      +50     
+ Misses      15624    14640     -984     
- Partials     2997     3939     +942     
Flag Coverage Δ
Archlinux 0.00% <0.00%> (ø)
FreeBSD-aarch64 ?
FreeBSD-amd64 13.24% <44.44%> (+0.03%) ⬆️
Homebrew-macos-14 20.33% <39.13%> (+0.04%) ⬆️
Homebrew-macos-15 20.98% <52.17%> (+0.52%) ⬆️
Homebrew-macos-26 21.09% <52.17%> (+0.49%) ⬆️
Homebrew-ubuntu-24.04 12.93% <45.00%> (+0.01%) ⬆️
Linux-AppImage 12.27% <45.00%> (+0.01%) ⬆️
Windows-AMD64 15.19% <40.90%> (+0.01%) ⬆️
Windows-ARM64 13.27% <42.85%> (+0.03%) ⬆️
macOS-arm64 17.74% <37.50%> (+0.05%) ⬆️
macOS-x86_64 18.42% <37.50%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/video.h 65.07% <ø> (+3.17%) ⬆️
src/video.cpp 53.86% <48.38%> (+1.57%) ⬆️

... and 39 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6bef33...048b9f2. Read the comment docs.

@ReenigneArcher
ReenigneArcher force-pushed the fix/amf/enable-H.264-profile-and-coder-selection-alternate branch from 82767cb to 048b9f2 Compare July 23, 2026 23:36
@sonarqubecloud

Copy link
Copy Markdown

@ReenigneArcher
ReenigneArcher marked this pull request as ready for review July 23, 2026 23:57
@ReenigneArcher
ReenigneArcher merged commit c8325cb into master Jul 24, 2026
69 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/amf/enable-H.264-profile-and-coder-selection-alternate branch July 24, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants