Skip to content

style(homebrew): fix homebrew validation - #5620

Merged
ReenigneArcher merged 1 commit into
masterfrom
style/homebrew-lint
Sep 5, 2026
Merged

style(homebrew): fix homebrew validation#5620
ReenigneArcher merged 1 commit into
masterfrom
style/homebrew-lint

Conversation

@ReenigneArcher

Copy link
Copy Markdown
Member

Description

Fixes new homebrew errors.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

See our AI usage policy.

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Bundle Report

Bundle size has no change ✅

@sonarqubecloud

sonarqubecloud Bot commented Sep 5, 2026

Copy link
Copy Markdown

@codecov

codecov Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.26%. Comparing base (d776227) to head (68f1064).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5620      +/-   ##
==========================================
+ Coverage   36.36%   37.26%   +0.90%     
==========================================
  Files         102      104       +2     
  Lines       25568    25880     +312     
  Branches    11166    11419     +253     
==========================================
+ Hits         9297     9644     +347     
+ Misses      15138    14453     -685     
- Partials     1133     1783     +650     
Flag Coverage Δ
Archlinux 20.90% <ø> (ø)
FreeBSD-amd64 23.23% <ø> (+0.01%) ⬆️
Homebrew-macos-14 36.25% <ø> (ø)
Homebrew-macos-15 36.82% <ø> (ø)
Homebrew-macos-26 37.13% <ø> (ø)
Homebrew-ubuntu-24.04 24.90% <ø> (ø)
Linux-AppImage 24.33% <ø> (ø)
Windows-AMD64 30.03% <ø> (?)
Windows-ARM64 25.19% <ø> (ø)
macOS-arm64 30.59% <ø> (ø)
macOS-x86_64 31.20% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 45 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d776227...68f1064. Read the comment docs.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Last Updated 2026-09-05 20:44:15 UTC
Source Run CI Run #5303
Commit 68f1064c25c3ea1b8513b61a38f1b73658e89402

Screenshot Comparison

PR #5620 screenshots vs screenshots baseline.

Matrix: AppImage

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-AMD64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: Windows-ARM64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-arm64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

Matrix: macOS-x86_64

Image Baseline PR
sunshine_tray_initial.png
sunshine_tray_menu.png
sunshine_tray_pairing_request.png
sunshine_tray_paused.png
sunshine_tray_stopped.png
sunshine_tray_streaming.png
sunshine_tray_tooltip.png

@ReenigneArcher
ReenigneArcher merged commit 53bc71b into master Sep 5, 2026
121 of 125 checks passed
@ReenigneArcher
ReenigneArcher deleted the style/homebrew-lint branch September 5, 2026 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant