Fix Audio Haptics toggle, rename Haptics to HD Haptics, add controller mock#1
Merged
Conversation
…r mock The header switch labeled "Audio Haptics" only toggled the panel view (setAudioHapticsOpen), not the feature, so users could never disable audio-reactive haptics. It now enables/disables audioReactiveHapticsEnabled and syncs the panel open state (toggleAudioHapticsFeature). Also make the firmware SET_AUDIO_REACTIVE_HAPTICS command best-effort: persisting the setting and reconciling the host mirror engine no longer depend on the firmware ack, which no-ops (and throws) when the DSP is already at 0 and settings_revision does not advance -- previously leaving the host audio-helper mirror running after a disable. Rename the user-facing "Haptics" label to "HD Haptics" (selector, card header, Overview slider, summary, status text, aria-labels), keeping "Rumble" and "Audio Haptics" distinct and the nav tab name unchanged. Add MockCompanionTransport (gated by DS5_BRIDGE_MOCK_CONTROLLER=1) so the layout-check and visual-smoke UI scripts can render the app in its connected state without real hardware.
LordVicky
force-pushed
the
fix-audio-haptics-toggle
branch
from
July 8, 2026 09:30
8463771 to
0cecd4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setAudioHapticsOpen), not the feature, so users could never disable audio-reactive haptics. It now enables/disablesaudioReactiveHapticsEnabledand syncs the panel open state.SET_AUDIO_REACTIVE_HAPTICSack, which no-ops (and throws) when the DSP is already at 0 andsettings_revisiondoesn't advance — previously leaving the hostaudio-helper-linux.mjsmirror running after a disable.MockCompanionTransport(gated byDS5_BRIDGE_MOCK_CONTROLLER=1) solayout-check/visual-smokeUI scripts render the app connected without real hardware.Testing
npx vitest run— 227 passing (incl. newmock-companion-transportandapp-behaviortests)tsctypecheck cleanNote
The full
layout-check.mjsstill trips on a pre-existing startup-tutorial "Continue In 5" countdown gate, unrelated to these changes.