Skip to content

Conversation

@guerinclement
Copy link
Collaborator

Description

This PR follows #521 to address the issue #520.
It is based on the branch to be merged in #521 so it must be merged after.

The code based is linted with flake8.
precommit config file is provided as well.

Fixes #520

Type of change

  • Global code linting

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run all tests succesfully

Test Configuration:

  • OS: CentOS
  • Python version: 3.10.8
  • Shapash version: 2.4.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Collaborator

@guillaume-vignal guillaume-vignal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guerinclement , can you check my comments ?
Thanks

Copy link
Collaborator

@guillaume-vignal guillaume-vignal Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the line compute_method = "phik" seems to be useless

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Collaborator

@guillaume-vignal guillaume-vignal Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we delete the commented lines ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

@guillaume-vignal guillaume-vignal self-requested a review February 8, 2024 09:12
@guillaume-vignal guillaume-vignal merged commit 17b92bd into MAIF:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve globally the code of shapash

2 participants