Skip to content

fix(mimic-iv-note): correct postgres quickstart data paths - #2109

Merged
alistairewj merged 1 commit into
MIT-LCP:mainfrom
acnimma:fix/note-postgres-quickstart-paths
Jul 25, 2026
Merged

fix(mimic-iv-note): correct postgres quickstart data paths#2109
alistairewj merged 1 commit into
MIT-LCP:mainfrom
acnimma:fix/note-postgres-quickstart-paths

Conversation

@acnimma

@acnimma acnimma commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • mimic_data_dir -> mimic-iv/2.2/note after the wget mv
  • Fix cleanup paths and remove stray rmdir rm

Test plan

  • Paths match a fresh wget + mv tree

The note postgres quickstart renames the download tree to mimic-iv, but still pointed mimic_data_dir at the nested mimic-iv/mimic-iv-note/... path and used rmdir rm in the cleanup comment.

After mv mimic-iv-note -> mimic-iv, data lives at mimic-iv/2.2/note, not
mimic-iv/mimic-iv-note/2.2/note. Also drop the stray "rmdir rm".
@alistairewj

Copy link
Copy Markdown
Member

the commented out paths are still incorrect but I'm merging for convenience since they are commented out and the real fix is there

@alistairewj
alistairewj merged commit 918284d into MIT-LCP:main Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants