Clean up: remove old mrpt version fallback code sections - #121
Merged
Conversation
jlblancoc
enabled auto-merge
April 4, 2026 06:04
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (2)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughRemoved MRPT-version conditional compilation across dataset, rosbag2, and map modules: standardized on CGenericPointsMap and unified point-field buffer access patterns; a few include lines received inline comments and a CMake MRPT minimum version was raised. Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mola_input_mulran_dataset/src/MulranDataset.cpp`:
- Around line 271-274: The CI failure is due to clang-format complaining about
the multi-line call to lstPointCloudFiles_.erase(std::next(...)) in
MulranDataset.cpp; fix it by reformatting that expression (either collapsing the
call to a single line or adjusting line breaks to match the project's
clang-format rules) and then run clang-format --style=file -i
mola_input_mulran_dataset/src/MulranDataset.cpp to apply the canonical
formatting; ensure the call still uses std::next(lstPointCloudFiles_.begin(),
static_cast<std::vector<std::string>::difference_type>(idx)) and preserves
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 41e263e4-275e-41ab-8bad-fbb7ba7257c4
📒 Files selected for processing (8)
mola_bridge_ros2/src/BridgeROS2.cppmola_input_kitti360_dataset/src/Kitti360Dataset.cppmola_input_mulran_dataset/src/MulranDataset.cppmola_input_paris_luco_dataset/src/ParisLucoDataset.cppmola_input_rawlog/include/mola_input_rawlog/RawlogDataset.hmola_input_rosbag2/src/Rosbag2Dataset.cppmola_kernel/include/mola_kernel/interfaces/RawDataSourceBase.hmola_metric_maps/src/KeyframePointCloudMap.cpp
💤 Files with no reviewable changes (1)
- mola_input_kitti360_dataset/src/Kitti360Dataset.cpp
jlblancoc
force-pushed
the
fix/clean-up-old-mrpt-version-checks
branch
from
April 4, 2026 19:17
5773885 to
6e361dc
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
mola_kernel/include/mola_kernel/interfaces/RawDataSourceBase.h (1)
30-113:⚠️ Potential issue | 🔴 CriticalAdd missing
#endifdirective to close the preprocessor conditional guard.Line 30 opens
#if MRPT_VERSION >= 0x020f07but the header has no matching#endif. This is a compilation blocker.Proposed fix
} // namespace mola + +#endif // MRPT_VERSION >= 0x020f07🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@mola_kernel/include/mola_kernel/interfaces/RawDataSourceBase.h` around lines 30 - 113, The header opens a preprocessor conditional with "#if MRPT_VERSION >= 0x020f07" but never closes it, causing compilation errors; fix by adding the matching "#endif" at the end of the file (after the closing brace of namespace mola and before EOF) to close the conditional that guards the RawDataSourceBase declaration and related includes, ensuring the MRPT_VERSION macro condition properly wraps the includes, class RawDataSourceBase, and associated declarations.
♻️ Duplicate comments (1)
mola_input_mulran_dataset/src/MulranDataset.cpp (1)
271-274:⚠️ Potential issue | 🟡 MinorCI clang-format failure persists—run formatter to fix.
The pipeline reports a clang-format error around line 268. Although a previous fix was attempted, the CI is still failing.
clang-format --style=file -i mola_input_mulran_dataset/src/MulranDataset.cpp🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@mola_input_mulran_dataset/src/MulranDataset.cpp` around lines 271 - 274, Run the project clang formatter on MulranDataset.cpp to fix the remaining style issues around the erase call; locate the use of lstPointCloudFiles_.erase(std::next(lstPointCloudFiles_.begin(), static_cast<std::vector<std::string>::difference_type>(idx))) and reformat the file (e.g., run clang-format --style=file -i mola_input_mulran_dataset/src/MulranDataset.cpp) so the expression spacing/line breaks conform to the repository clang-format rules.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@mola_kernel/include/mola_kernel/interfaces/RawDataSourceBase.h`:
- Around line 30-113: The header opens a preprocessor conditional with "#if
MRPT_VERSION >= 0x020f07" but never closes it, causing compilation errors; fix
by adding the matching "#endif" at the end of the file (after the closing brace
of namespace mola and before EOF) to close the conditional that guards the
RawDataSourceBase declaration and related includes, ensuring the MRPT_VERSION
macro condition properly wraps the includes, class RawDataSourceBase, and
associated declarations.
---
Duplicate comments:
In `@mola_input_mulran_dataset/src/MulranDataset.cpp`:
- Around line 271-274: Run the project clang formatter on MulranDataset.cpp to
fix the remaining style issues around the erase call; locate the use of
lstPointCloudFiles_.erase(std::next(lstPointCloudFiles_.begin(),
static_cast<std::vector<std::string>::difference_type>(idx))) and reformat the
file (e.g., run clang-format --style=file -i
mola_input_mulran_dataset/src/MulranDataset.cpp) so the expression spacing/line
breaks conform to the repository clang-format rules.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ab05d5c9-0cc0-45f8-8894-6ace9a3766da
📒 Files selected for processing (8)
mola_bridge_ros2/src/BridgeROS2.cppmola_input_kitti360_dataset/src/Kitti360Dataset.cppmola_input_mulran_dataset/src/MulranDataset.cppmola_input_paris_luco_dataset/src/ParisLucoDataset.cppmola_input_rawlog/include/mola_input_rawlog/RawlogDataset.hmola_input_rosbag2/src/Rosbag2Dataset.cppmola_kernel/include/mola_kernel/interfaces/RawDataSourceBase.hmola_metric_maps/src/KeyframePointCloudMap.cpp
💤 Files with no reviewable changes (1)
- mola_input_kitti360_dataset/src/Kitti360Dataset.cpp
✅ Files skipped from review due to trivial changes (2)
- mola_metric_maps/src/KeyframePointCloudMap.cpp
- mola_bridge_ros2/src/BridgeROS2.cpp
🚧 Files skipped from review as they are similar to previous changes (3)
- mola_input_rawlog/include/mola_input_rawlog/RawlogDataset.h
- mola_input_paris_luco_dataset/src/ParisLucoDataset.cpp
- mola_input_rosbag2/src/Rosbag2Dataset.cpp
jlblancoc
force-pushed
the
fix/clean-up-old-mrpt-version-checks
branch
from
April 4, 2026 19:23
6e361dc to
6a182b9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@mola_input_mulran_dataset/src/MulranDataset.cpp`:
- Line 30: The code now uses mrpt::maps::CGenericPointsMap and calls
loadFromKittiVelodyneFile(), which require MRPT >= 2.15.0; update the project's
minimum MRPT version to at least 2.15.0 in the global CMake configuration (the
declared minimum in your CMakeLists) and add an explicit version check in the
input-mulran dataset CMakeLists to enforce find_package(MRPT REQUIRED COMPONENTS
maps VERSION 2.15.0 OR_GREATER) (or the equivalent version check) so builds with
older MRPT (e.g., 2.1.0) fail early rather than causing compile errors when
using CGenericPointsMap/loadFromKittiVelodyneFile.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5f68cf70-1b4b-43cd-85d0-96e15e7438f6
📒 Files selected for processing (8)
mola_bridge_ros2/src/BridgeROS2.cppmola_input_kitti360_dataset/src/Kitti360Dataset.cppmola_input_mulran_dataset/src/MulranDataset.cppmola_input_paris_luco_dataset/src/ParisLucoDataset.cppmola_input_rawlog/include/mola_input_rawlog/RawlogDataset.hmola_input_rosbag2/src/Rosbag2Dataset.cppmola_kernel/include/mola_kernel/interfaces/RawDataSourceBase.hmola_metric_maps/src/KeyframePointCloudMap.cpp
💤 Files with no reviewable changes (2)
- mola_input_kitti360_dataset/src/Kitti360Dataset.cpp
- mola_input_rosbag2/src/Rosbag2Dataset.cpp
✅ Files skipped from review due to trivial changes (4)
- mola_bridge_ros2/src/BridgeROS2.cpp
- mola_metric_maps/src/KeyframePointCloudMap.cpp
- mola_kernel/include/mola_kernel/interfaces/RawDataSourceBase.h
- mola_input_paris_luco_dataset/src/ParisLucoDataset.cpp
🚧 Files skipped from review as they are similar to previous changes (1)
- mola_input_rawlog/include/mola_input_rawlog/RawlogDataset.h
jlblancoc
force-pushed
the
fix/clean-up-old-mrpt-version-checks
branch
from
April 4, 2026 20:46
6a182b9 to
092f9e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Bug Fixes