[ADDED] IDLE Worker Global Switch #1922
Conversation
Fixes #1921 once merged.
|
Tested on my TGC pool. I did find a possible issue, on the 'Pool workers' page the 'monitor' column is still displayed. I know when you disable all notifications this column disappears. |
|
Yeah will add that! |
|
@daygle done, can you test again? |
|
Unfortunately the column still displays... |
|
Did you pull this commit when you updated: 4f01b27 I tried it out while adding it and it worked for me with different options. Can only try again tomorrow just trying to confirm you have that change. |
|
Very weird? I trust that you have corrected it I'm just confused on why I'm having trouble. I'm on git checkout disable-worker-notifications and have ensured that there are no custom templates. |
|
Just check if that change I linked is actually added after a git pull. If yes I will have to check what i may have overlooked ;-) |
|
I have checked the code for 'disable-worker-notifications' branch online and your changes don't appear in this repository. The poolworkers/default.tpl page looks like it was last modified 2 months ago and doesn't include the fix. |
|
You were talking about the admin page! Now I get it ;-) I removed it from the accounts worker page so people can't enable/disable the monitor anymore. I shall fix it on the admin page too then we should be good to go. |
|
Haha now I see, we were both talking about different things. Oh well at least we are covering all areas :) |
|
There we go, please test this again. Should be good to go now! |
|
Perfect tested and everything is ok now. Thanks for the addition. |
[ADDED] IDLE Worker Global Switch
Fixes #1921 once merged.