Skip to content

Conversation

@TheSerapher
Copy link
Contributor

Prop and PPLNS will now allow a pool operator to run a pool bonus. It is based on the block reward and evenly paid as a percentage (default 0) to all miners.

PPS will pose a challenge since our block bonus is block bound (confirmations) and PPS does not care about blocks. So we can not easily bind a PPS pool bonus to a block.

Since PPS is not widely used, I think this a minor issue for now. Please test the Prop and PPLNS implementations, they worked fine on my testnet.

Fixes #1932 once merged.

@TheSerapher TheSerapher added this to the v1.0.0 milestone Mar 13, 2014
@TheSerapher TheSerapher self-assigned this Mar 13, 2014
@TheSerapher
Copy link
Contributor Author

2% is the bonus based on your block reward. I will add an option to switch between block value and actual users payout.

@torchwooduk
Copy link

I thought it was like fees based on users payout not the actual block reward, paying everyone even 1% based on the block reward would be very expensive.

@TheSerapher
Copy link
Contributor Author

@torchwooduk Please test it again. Default bonus method is now payout (percentage based on the users payout). It can be changed to block for a per-block value based bonus.

@TheSerapher
Copy link
Contributor Author

Ran it on my testnet with two payouts and it worked great - if someone else can confirm too that would be appreciated.

It allows running bonus based on payouts (the default) or you can switch to block, which will base your percentage on the block value.

PPS is not supported since Bonus payments requires a block to payout properly. We can look into this later but seeing there are only very few PPS pools out there, I'd probably just skip this.

@torchwooduk
Copy link

Been running it since yesterday, works fine, Thx

TheSerapher added a commit that referenced this pull request Mar 14, 2014
[FEATURE] Added Pool Bonus for Prop and PPLNS
@TheSerapher TheSerapher merged commit 9b36c9a into development Mar 14, 2014
@TheSerapher TheSerapher deleted the pool-bonus-feature branch March 14, 2014 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants